Date: Sun, 7 Sep 2014 15:34:35 -0700 From: yaneurabeya@gmail.com To: Glen Barber <gjb@FreeBSD.org> Cc: freebsd-current@freebsd.org Subject: Re: NO INET6 warning Message-ID: <B83C39FA-AA8B-4A8D-9441-2BD1BAC380FC@gmail.com> In-Reply-To: <20140907210802.GA48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
On Sep 7, 2014, at 14:08, Glen Barber <gjb@FreeBSD.org> wrote:
> On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote:
>> make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" =
line
>> 12: warning: Couldn't read shell's output for
>> "cat =
/home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZR-300H=
P/opt_inet6.h"
>>=20
>>=20
>> Shouldn't this cat be done in a saner way?
>>=20
>=20
> This is done quite often throughout the tree, and bmake(1) does not =
like
> it when there is no value assigned from the '!=3D' expansion.
>=20
> The fix I've seen most commonly done is to echo a newline after the
> assignment, such as:
>=20
> Index: sys/modules/if_gif/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/modules/if_gif/Makefile (revision 271215)
> +++ sys/modules/if_gif/Makefile (working copy)
> @@ -9,7 +9,7 @@ KMOD=3D if_gif
> SRCS=3D if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h
>=20
> .if defined(KERNBUILDDIR)
> -OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h
> +OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h; echo
> .if empty(OPT_INET6)
> MK_INET6_SUPPORT=3Dno
> .endif
Shouldn=92t this all be removed and replaced with equivalent =
logic provided by kern.opts.mk?
Thanks!
-Garrett
--Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJUDN17AAoJEMZr5QU6S73e2SgIAK5NsVZt3dNPCmKyBgs5VA7d
kR4RJdabmdE3+oaMH6YY8IKOvwoXtgvuABSS07UN1HWauDzkl/O6E63axlmGxYYh
B8T06rsPLUjTTROxuNssSV0B8upz5XC3Md/9K4dbYivTPWb2P9oFDX8HxNjQHkay
JZYR229n05be6V3tvJfvvbN2jhbEvep1B8g8Bpoo+CiJcyHOKyN9cKkVtPDPIa4l
JEqBzQb7bhXU6fIglMgmryYVQiLs7R17OVhQH73HVovoFdrFgQOP4qplgnNhV6Gm
+awmrmE1VbP/q2ETNON3do16BfpeaZshv9fB2E80GciOXtVjOZJR7qbsZqdWLDg=
=fa2Z
-----END PGP SIGNATURE-----
--Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B83C39FA-AA8B-4A8D-9441-2BD1BAC380FC>