Date: Fri, 22 Mar 2002 13:31:45 -0700 From: Ian <freebsd@damnhippie.dyndns.org> To: Gregory Neil Shapiro <gshapiro@freebsd.org>, <freebsd-stable@freebsd.org> Subject: Re: For Review: sendmail 8.12.2 import into -STABLE Message-ID: <B8C0E2C1.B5D1%freebsd@damnhippie.dyndns.org> In-Reply-To: <15513.38875.83457.102683@horsey.gshapiro.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> My goal is to commit these patches this weekend or the beginning of next > week depending on the feedback I receive. Positive testing feedback will > push it earlier, negative testing feedback may delay it. Looks good... I pulled a fresh copy of -STABLE into a new directory and used your instructions and patches with it, and everything worked perfectly. (I needed to do it with a new/fresh copy because my working copy of -STABLE had some local hacks to let me build and install libmilter even though it was still marked FFR. I didn't want my hacks to skew the results.) I ran into one small glitch, but I don't think it's your problem, I suspect the sendmail folks are at fault... for some reason in the new libmilter/mfapi.h the #include <sys/types.h> got moved down a few lines so it's after the #include <sys/socket.h>, causing compile failure on my existing milter code that was developed under 8.11.x. Easily fixed, I just included sys/types.h myself before mfapi.h (although I hate having to do things like that... if my code doesn't use anything directly from types.h I shouldn't have to include it). -- Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B8C0E2C1.B5D1%freebsd>