Date: Thu, 5 May 2011 14:55:18 -0400 From: Arnaud Lacombe <lacombar@gmail.com> To: Emil Muratov <gpm@hotplug.ru> Cc: freebsd-net@freebsd.org, Paolo Pisati <piso@freebsd.org> Subject: Re: nfe taskq kernel panic Message-ID: <BANLkTi=vBxUm83TCv8JDeSh%2BU4g0Y=WN3A@mail.gmail.com> In-Reply-To: <BANLkTimTUE_SvVUA1RWRBvLWeaYWvT62CQ@mail.gmail.com> References: <op.vu0q8asqaevz08@ghost-pc.home.lan> <BANLkTimvboyYGXL21vzeQ%2BgPOO4QCUGskQ@mail.gmail.com> <BANLkTimTUE_SvVUA1RWRBvLWeaYWvT62CQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Thu, May 5, 2011 at 2:49 PM, Arnaud Lacombe <lacombar@gmail.com> wrote: > There is a stale reference to the mbuf passed to, and freed in > m_megapullup(); could you test the following patch ? > > diff --git a/sys/netinet/ipfw/ip_fw_nat.c b/sys/netinet/ipfw/ip_fw_nat.c > index f8c3e63..80c13dc 100644 > --- a/sys/netinet/ipfw/ip_fw_nat.c > +++ b/sys/netinet/ipfw/ip_fw_nat.c > @@ -263,7 +263,7 @@ ipfw_nat(struct ip_fw_args *args, struct cfg_nat > *t, struct mbuf *m) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0retval =3D LibAliasOut(t->lib, c, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mcl->m_len + M_TRAILINGSPA= CE(mcl)); > =A0 =A0 =A0 =A0if (retval =3D=3D PKT_ALIAS_RESPOND) { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 m->m_flags |=3D M_SKIP_FIREWALL; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 mcl->m_flags |=3D M_SKIP_FIREWALL; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0retval =3D PKT_ALIAS_OK; > =A0 =A0 =A0 =A0} > =A0 =A0 =A0 =A0if (retval !=3D PKT_ALIAS_OK && > > This was introduced in r188294 by piso@ (added to the CC: list). > this can only happen if you are NAT'ing SCTP traffic. So it might not be the culprit in your case.. =A0- Arnaud
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=vBxUm83TCv8JDeSh%2BU4g0Y=WN3A>