Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jul 2016 11:42:11 -0700
From:      Mark Millard <markmi@dsl-only.net>
To:        jpaetzel@FreeBSD.org, FreeBSD Ports <freebsd-ports@freebsd.org>
Cc:        w.schwarzenfeld@utanet.at, mat@FreeBSD.org, koobs@FreeBSD.org
Subject:   Re: svn commit: r418841 - in head/benchmarks/iozone: . files
Message-ID:  <C1EB4E1E-E072-4BF7-86BA-76AF061AA511@dsl-only.net>
In-Reply-To: <8238CC04-1CFA-47DE-8605-9E07CA5B3EE6@dsl-only.net>
References:  <8238CC04-1CFA-47DE-8605-9E07CA5B3EE6@dsl-only.net>

next in thread | previous in thread | raw e-mail | index | archive | help
[This is a resend: Replying to svn-ports-head did not seem to go through =
so I'm trying freebsd-ports. I have fixed a typo.]

https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D418841 is =
broken on armv6, powerpc, and all other ILP32 FreeBSD architectures:

+-typedef long long off64_t;
++typedef long off64_t;

long is not 64-bits but only 32-bits for ILP32 FreeBSD architectures. =
FreeBSD uses 64 bits for off_t even for ILP32 architectures. For FreeBSD =
off_t and iozone's off64_t need to be compatible.

Use of %ld instead of %lld formats have the same issue with ILP32 =
FreeBSD architectures.

+-			sscanf(optarg,"%lld",&kilobytes64);
++			sscanf(optarg,"%ld",&kilobytes64);



See the activity at:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211152


=3D=3D=3D
Mark Millard
markmi at dsl-only.net





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C1EB4E1E-E072-4BF7-86BA-76AF061AA511>