Date: Fri, 25 Apr 2014 17:35:32 +0200 From: Stefan Bethke <stb@lassitu.de> To: Robert Backhaus <robbak@robbak.com> Cc: Boris Samorodov <bsam@passap.ru>, Freebsd_mailinglist_PORTS <freebsd-ports@freebsd.org> Subject: Re: foomatic-rip and foo2zjs Message-ID: <C30C335D-DCA2-4B26-A9E6-400361ABFBF4@lassitu.de> In-Reply-To: <CABG_4j=HydwYgJizCCwsdQD7A3-D=64YkBsb10xTsRweU7Hvqw@mail.gmail.com> References: <338BD4B8-F25A-4CC5-A5FA-451C48BB5A5C@lassitu.de> <535A4E09.5000006@passap.ru> <CABG_4j=HydwYgJizCCwsdQD7A3-D=64YkBsb10xTsRweU7Hvqw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
Am 25.04.2014 um 15:20 schrieb Robert Backhaus <robbak@robbak.com>:
> Anyway, here's a backtrace: - but the pointed line, 1200, just looks =
wrong -=20
>=20
> int fd =3D mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built =
- Yup, that's it. Here's the patch:
>=20
> --- foomaticrip.c.orig 2014-04-25 23:16:06.000000000 +1000
> +++ foomaticrip.c 2014-04-25 23:16:47.000000000 +1000
> @@ -1197,7 +1197,7 @@
> debug =3D 1;
> =20
> if (debug) {
> - int fd =3D mkstemp (LOG_FILE "-XXXXXX.log");
> + int fd =3D mkstemp ("LOG_FILE-XXXXXX.log");
> if (fd !=3D -1)
> logh =3D fdopen(fd, "w");
> else
Sorry, that patch does=92t look right to me. LOG_FILE should be a define =
that get=92s concatenated with the string literal. Since this is =
compile-time, I don=92t see how this would lead to a runtime error, =
unless LOG_FILE was defined to some unusual value.
Stefan
--=20
Stefan Bethke <stb@lassitu.de> Fon +49 151 14070811
--Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJTWoDFAAoJEA/POViuFuLBUb0IAJRH2VMsIngQUDa3JXcNIUSI
wFwgNvSOFu3p4I+Pg/wclbV5Nrkbg7LnFzPvqRFX5hV1RweUb/8I87vG1q3tNIG5
Uan5SvhgFQv2Ttyna1HuMFWbaECYI/25DNDfZixSwEl6lmky9LojHdjn8fX47+GA
iqVuYwZqCHtok2LErdJT9gCqPoJTSQ3GJiudf6Ldb2YiafajHWjxYzm2g+kz0UTt
ktJxvx5qQOpr0vo1NBslx9wo2p5g/Bkj4CrIS9BmscsbpvrBQJY4IqgyEWnh6ozx
SOt+vh6aMCAQbWvMV0xOdmqZW+eS/z/HyZbyWYSyi9cACmKzpLXgrRp3QZzFsYE=
=dSJs
-----END PGP SIGNATURE-----
--Apple-Mail=_CAF72F26-C854-410A-AA84-D4D554950420--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C30C335D-DCA2-4B26-A9E6-400361ABFBF4>