Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 May 2012 15:08:31 -0400
From:      Robert Simmons <rsimmons0@gmail.com>
To:        freebsd-ports@freebsd.org
Subject:   Re: Heimdal 1.5.2 problem
Message-ID:  <CA%2BQLa9CBOw4HywRELLB8%2BCE%2Bc7t572bXdJhPi40smQxzT1LC4Q@mail.gmail.com>
In-Reply-To: <20120522125710.GB18115@atarininja.org>
References:  <CA%2BQLa9ArX15Cgtyq%2B7PhhXtGGOj1dtVM4pisGfkFzVDJE7cs8A@mail.gmail.com> <4FAD492C.3060807@gmx.de> <CA%2BQLa9CyVUmvy=NzHiP73iTTRKVqU9Eza=PPMmLZrogoUn_gAg@mail.gmail.com> <CA%2BQLa9AC_mDrBiPaYOJ_M3F%2Bq07aUV1TATJcFgxSKCr2gPOFWw@mail.gmail.com> <9880B4F2567E41A582B6B9DA178AECFD@black> <CA%2BQLa9Bs1VSBoMW0cHvSSeET=9X7F--33iv=860FzKv%2BHYuqNg@mail.gmail.com> <CA%2BQLa9CeMN9=FF_BuKNeADuVkK5Hs74_MxsB97_zKRkT9hkDug@mail.gmail.com> <20120522125710.GB18115@atarininja.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--f46d043890939318d904c0a4bee6
Content-Type: text/plain; charset=ISO-8859-1

On Tue, May 22, 2012 at 8:57 AM, Wesley Shields <wxs@freebsd.org> wrote:
> As the person who committed this update I will take responsibility for
> seeing this through. Would you mind opening a PR with this patch and CC
> both myself and the maintainer so it can be properly tracked. I will
> work with both of you to make sure it is addressed.

I got some good feedback about the patch.  I was missing a "\".  Also,
it was noted that I shouldn't make changes to the default settings in
this patch since it is meant to correct a problem.  I removed the
change to default.

Perhaps the different default is not the best solution.  Maybe there
should be a message that at least one backend is needed for the port
to function, but none have been selected by default?

I have attached the updated patch, and I've opened a PR here:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168214

--f46d043890939318d904c0a4bee6
Content-Type: text/plain; charset=US-ASCII; name="patch.txt"
Content-Disposition: attachment; filename="patch.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_h2jc6ak30

LS0tIHBvcnRzL3NlY3VyaXR5L2hlaW1kYWwvTWFrZWZpbGUub2xkCTIwMTItMDUtMjAgMTY6MTk6
MzkuMDAwMDAwMDAwIC0wNDAwCisrKyBwb3J0cy9zZWN1cml0eS9oZWltZGFsL01ha2VmaWxlCTIw
MTItMDUtMjEgMDY6NTg6MzQuMDAwMDAwMDAwIC0wNDAwCkBAIC03LDEzICs3LDEyIEBACiAKIFBP
UlROQU1FPQloZWltZGFsCiBQT1JUVkVSU0lPTj0JMS41LjIKLVBPUlRSRVZJU0lPTj0JMQorUE9S
VFJFVklTSU9OPQkyCiBDQVRFR09SSUVTPQlzZWN1cml0eSBpcHY2CiBNQVNURVJfU0lURVM9CWh0
dHA6Ly93d3cuaDVsLm9yZy9kaXN0L3NyYy8gXAogCQlodHRwOi8vZnRwLnBkYy5rdGguc2UvcHVi
L2hlaW1kYWwvc3JjLyBcCiAJCWZ0cDovL2Z0cC5wZGMua3RoLnNlL3B1Yi9oZWltZGFsL3NyYy8g
XAotCQlmdHA6Ly9mdHAuc3VuZXQuc2UvcHViL3VuaXgvYWRtaW4vbWlycm9yLXBkYy9oZWltZGFs
L3NyYy8gXAotCQlmdHA6Ly9mdHAuYXlhbXVyYS5vcmcvcHViL2hlaW1kYWwvCisJCWZ0cDovL2Z0
cC5zdW5ldC5zZS9wdWIvdW5peC9hZG1pbi9taXJyb3ItcGRjL2hlaW1kYWwvc3JjLwogCiBNQUlO
VEFJTkVSPQlKb2VyZy5QdWx6QGZybTIudHVtLmRlCiBDT01NRU5UPQlBIHBvcHVsYXIgQlNELWxp
Y2Vuc2VkIGltcGxlbWVudGF0aW9uIG9mIEtlcmJlcm9zIDUKQEAgLTc3LDEwICs3NiwxMCBAQAog
Q0ZMQUdTKz0JLUkke0JEQl9JTkNMVURFX0RJUn0KIENQUEZMQUdTKz0JLUkke0JEQl9JTkNMVURF
X0RJUn0KIExERkxBR1MrPQktTCR7QkRCX0xJQl9ESVJ9Ci1DT05GSUdVUkVfQVJHUys9CS0td2l0
aC1iZXJrZWxleS1kYj0ke0xPQ0FMQkFTRX0KLSMJCQktLXdpdGgtYmVya2VsZXktZGItaW5jbHVk
ZT0ke0JEQl9JTkNMVURFX0RJUn0KK0NPTkZJR1VSRV9BUkdTKz0JLS13aXRoLWJlcmtlbGV5LWRi
PSR7TE9DQUxCQVNFfSBcCisJCQktLXdpdGgtYmVya2VsZXktZGItaW5jbHVkZT0ke0JEQl9JTkNM
VURFX0RJUn0KIC5lbHNlCi1DT05GSUdVUkVfQVJHUys9CS0td2l0aG91dC1iZXJrZWxleS1kYgor
Q09ORklHVVJFX0FSR1MrPQktLXdpdGgtYmVya2VsZXktZGI9bm8KIC5lbmRpZgogCiAuaWYgZGVm
aW5lZChXSVRIX1NRTElURSkK
--f46d043890939318d904c0a4bee6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BQLa9CBOw4HywRELLB8%2BCE%2Bc7t572bXdJhPi40smQxzT1LC4Q>