Date: Thu, 26 May 2022 16:32:01 +0300 From: Odhiambo Washington <odhiambo@gmail.com> To: Stefan Haller <stefan+freebsd@stha.de> Cc: User Questions <freebsd-questions@freebsd.org> Subject: Re: pf.conf macros not working - syntax error Message-ID: <CAAdA2WN1ecNZUqPYRVTDtJP5kFHn%2BvvPm07HAVMrcy8kxdD5tA@mail.gmail.com> In-Reply-To: <Yo92eH4XOc8tYNkn@stha.de> References: <Yo92eH4XOc8tYNkn@stha.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000064a29905dfea3932
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Thu, May 26, 2022 at 3:46 PM Stefan Haller <stefan+freebsd@stha.de>
wrote:
> Hi,
>
> when playing around with my pf.conf ruleset I came across the following
> oddity:
>
> If I define a macro in the following way:
>
> > foo =3D "10.0.0.1"
> > bar =3D "10.1.0.1"
> > baz =3D "{" $foo $bar "}"
>
> I can later use the macro $baz inside a filter rule.
>
> However, if I store subnets in my macros it does not work. This can
> easily be verify by having a file containing only the following three
> lines and using `pfctl -nvf file`:
>
> > foo =3D "10.0.0.0/24"
> > bar =3D "10.1.0.0/24"
> > baz =3D "{" $foo $bar "}"
>
> I get:
>
> > /tmp/test:3: syntax error
>
> According to the section "macros" in `man 5 pf.conf` the macro
> definition is totally legit. Could this be a bug in FreeBSD? Just wanted
> to ask the list if I am missing something. I tested it on 13.1-RELEASE
> and CURRENT, I always get a syntax error.
>
Why do you need so many " " ? Can you please remove the double quotes
inside the braces?
You already quoted the foo and bar so I see no need to re-quote them inside
the braces.
[16:24 ~ ]$ pfctl -nvf file
foo =3D "10.0.0.0/24"
bar =3D "10.1.0.0/24"
baz =3D "{ $foo $bar }"
The syntax errors go away once you change the baz =3D by removing unnecessa=
ry
quotes :)
--=20
Best regards,
Odhiambo WASHINGTON,
Nairobi,KE
+254 7 3200 0004/+254 7 2274 3223
"Oh, the cruft.", egrep -v '^$|^.*#' =C2=AF\_(=E3=83=84)_/=C2=AF :-)
--00000000000064a29905dfea3932
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 26, 2022 at 3:46 PM Stefa=
n Haller <<a href=3D"mailto:stefan%2Bfreebsd@stha.de">stefan+freebsd@sth=
a.de</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex">Hi,<br>
<br>
when playing around with my pf.conf ruleset I came across the following<br>
oddity:<br>
<br>
If I define a macro in the following way:<br>
<br>
> foo =3D "10.0.0.1"<br>
> bar =3D "10.1.0.1"<br>
> baz =3D "{" $foo $bar "}"<br>
<br>
I can later use the macro $baz inside a filter rule.<br>
<br>
However, if I store subnets in my macros it does not work. This can<br>
easily be verify by having a file containing only the following three<br>
lines and using `pfctl -nvf file`:<br>
<br>
> foo =3D "<a href=3D"http://10.0.0.0/24" rel=3D"noreferrer" target=
=3D"_blank">10.0.0.0/24</a>"<br>
> bar =3D "<a href=3D"http://10.1.0.0/24" rel=3D"noreferrer" target=
=3D"_blank">10.1.0.0/24</a>"<br>
> baz =3D "{" $foo $bar "}"<br>
<br>
I get:<br>
<br>
> /tmp/test:3: syntax error<br>
<br>
According to the section "macros" in `man 5 pf.conf` the macro<br=
>
definition is totally legit. Could this be a bug in FreeBSD? Just wanted<br=
>
to ask the list if I am missing something. I tested it on 13.1-RELEASE<br>
and CURRENT, I always get a syntax error.<br></blockquote><div>=C2=A0</div>=
<div>Why do you need so many " " ? Can you please remove the doub=
le quotes inside the braces?</div><div>You already quoted the foo and bar s=
o I see no need to re-quote them inside the braces.</div><div><br></div>[16=
:24 ~ ]$ pfctl -nvf file<br>foo =3D "<a href=3D"http://10.0.0.0/24">10=
.0.0.0/24</a>"<br>bar =3D "<a href=3D"http://10.1.0.0/24">10.1.0.=
0/24</a>"<br><div>baz =3D "{ $foo $bar }"</div><div><br></di=
v><div>The syntax errors go away once you change the baz =3D by removing un=
necessary quotes :)</div><div><br></div><div>=C2=A0</div></div><br clear=3D=
"all"><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div=
dir=3D"ltr"><div dir=3D"ltr"><div>Best regards,<br>Odhiambo WASHINGTON,<br=
>Nairobi,KE<br>+254 7 3200 0004/+254 7 2274 3223<br>"<span style=3D"fo=
nt-size:12.8px">Oh, the cruft.</span><span style=3D"font-size:12.8px">"=
;,=C2=A0</span><span style=3D"font-size:12.8px">egrep -v '^$|^.*#'=
=C2=A0</span><span style=3D"background-color:rgb(34,34,34);color:rgb(238,23=
8,238);font-family:"Lucida Console",Consolas,"Courier New&qu=
ot;,monospace;font-size:13.6px">=C2=AF\_(=E3=83=84)_/=C2=AF</span><span sty=
le=3D"font-size:12.8px">=C2=A0:-)</span></div></div></div></div></div>
--00000000000064a29905dfea3932--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAdA2WN1ecNZUqPYRVTDtJP5kFHn%2BvvPm07HAVMrcy8kxdD5tA>