Date: Wed, 12 Oct 2016 13:15:30 -0500 From: Kyle Evans <kevans91@ksu.edu> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: qa.sh stripped warning Message-ID: <CACNAnaHm1a0Hz-=HPt59pZ8%2BjQEsX4s=vsc_izg9iyw6OObWEg@mail.gmail.com> In-Reply-To: <a7c84b19-0b61-0584-0bad-ef0ecfc2864c@FreeBSD.org> References: <CACNAnaH=bfFDy0rgO2_VPtx3U6k6uwM1HneVbR-S0YztXYsr3A@mail.gmail.com> <a7c84b19-0b61-0584-0bad-ef0ecfc2864c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Wed, Oct 12, 2016 at 10:35 AM, Mathieu Arnold <mat@freebsd.org> wrote: > The warning will never be turned into errors. Maybe add a comment to the > makefile saying that files must not be stripped. Maybe a bit like go > ports do it, something like: > > STRIP= # Elf firmwares, do not strip Thanks for the suggestion! I've implemented this. Given the strong wording you've used here (will never be turned into errors), would you consider revising the comment @ https://svnweb.freebsd.org/ports/head/Mk/Scripts/qa.sh?view=markup#l191 ? It's easy to derive uncertainty from the wording used in the comment.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHm1a0Hz-=HPt59pZ8%2BjQEsX4s=vsc_izg9iyw6OObWEg>