Date: Sat, 8 Oct 2011 18:35:13 +0100 From: Chris Rees <utisoft@gmail.com> To: Stanislav Sedov <stas@freebsd.org> Cc: Mykola Dzham <i@levsha.me>, current@freebsd.org, pp@gmail.com, "portmgr@freebsd.org" <portmgr@freebsd.org>, jilles@freebsd.org Subject: Re: ports on 10.0-CURRENT: r226027 is incorrect fix Message-ID: <CADLo83-3m0L=tvRiasQbroS%2BUwyJF5cU7mBaSpw9pjSnAEn0RQ@mail.gmail.com> In-Reply-To: <20111007164411.554ac9c0.stas@FreeBSD.org> References: <20111007230336.GB3051@laptop.levsha.me> <20111007164411.554ac9c0.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 Oct 2011 00:45, "Stanislav Sedov" <stas@freebsd.org> wrote:
>
> On Sat, 8 Oct 2011 02:03:37 +0300
> Mykola Dzham <i@levsha.me> mentioned:
>
> > Hi!
> > r226027 fix ( ... s/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/ ...) is
> > incorrect: this commit breaks metaports building:
> >
> > # cd /usr/ports/print/teTeX && sudo make clean all
> > ===> Cleaning for teTeX-3.0_5
> > ===> License check disabled, port has not defined LICENSE
> > ===> Found saved configuration for teTeX-3.0_2
> > ===> Extracting for teTeX-3.0_5
> > ===> Patching for teTeX-3.0_5
> > ===> Configuring for teTeX-3.0_5
> > find /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0 -type f \( -name
config.libpath -o -name config.rpath -o -name configure -o -name libtool.m4
\) -exec sed -i '' -e 's/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/' -e
's/freebsd\[123\]\*)/SHOULDNOTMATCHANYTHING2)/' {} +
> > find: /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0: No such file or
directory
> > *** Error code 1
> >
> > Stop in /usr/ports/print/teTeX.
> > *** Error code 1
> >
> > Stop in /usr/ports/print/teTeX.
> >
> > I think this commit should be reverted. Using UNAME_r is less
destructive work around
> >
>
> Hi!
>
> I just committed the fix that checks if the ${WRKSRC} directory exists
firts.
>
>
Last I heard, portmgr explicitly disapproved of this fix-- have I missed
something??? Erwin specifically said not to do it.
Since when can anyone just commit stuff to bsd.port.mk, regardless of its
location?
This is a bad solution, please revert it or I will when I get back. We're
going to end up being asked to support it on ports@ otherwise.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-3m0L=tvRiasQbroS%2BUwyJF5cU7mBaSpw9pjSnAEn0RQ>