Date: Thu, 1 Mar 2012 12:38:01 +0000
From: Chris Rees <utisoft@gmail.com>
To: Matthew Seaman <matthew@freebsd.org>
Cc: freebsd-ports <freebsd-ports@freebsd.org>
Subject: Re: On the usage of ${FILE}
Message-ID: <CADLo83-9TZWG9C7N0169HxxRJtPgAAvcYhA2UXQ2GpSNxGHkHw@mail.gmail.com>
In-Reply-To: <4F4F5C76.8040908@FreeBSD.org>
References: <4F4F5C76.8040908@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Mar 2012 11:26, "Matthew Seaman" <matthew@freebsd.org> wrote:
>
>
> Dear all,
>
> bsd.commands.mk has the following:
>
> FILE?= /usr/bin/file
>
> which is unfortunate, given that ${FILE} is used in several thousand
> ports, generally as a loop control variable for iterating through a list
> of files. In fact, I can only find about 8 places where the file(1)
> program is intended.
>
> This obvious conflict of meanings seems pretty undesirable to me. Am I
> missing something? Is there any reason to keep the status quo rather
> than changing the bsd.commands.mk variable to FILE_CMD and making the
> corresponding changes in those 8 places?
>
> Cheers,
>
> Matthew
>
I think that the loop control variables should be renamed to lower case.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-9TZWG9C7N0169HxxRJtPgAAvcYhA2UXQ2GpSNxGHkHw>