Date: Sun, 24 Jun 2012 15:13:26 -0700 From: Eitan Adler <lists@eitanadler.com> To: Doug Barton <dougb@freebsd.org> Cc: Alex Kozlov <spam@rm-rf.kiev.ua>, FreeBSD ports list <freebsd-ports@freebsd.org> Subject: Re: X11BASE still in use in ports Message-ID: <CAF6rxgkRyic4Mfp03sxVimBP6h8tdGH=unmE-xpZLDuAoCbWTg@mail.gmail.com> In-Reply-To: <4FE78DF5.1090709@FreeBSD.org> References: <4FE6F010.80609@FreeBSD.org> <CAF6rxg=Mv0j4QnK0QTZDxVx=TqwNJMg0NSNHxKbOLwK9w=wbrQ@mail.gmail.com> <4FE78DF5.1090709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 June 2012 15:00, Doug Barton <dougb@freebsd.org> wrote:
> On 06/24/2012 11:05, Eitan Adler wrote:
>> On 24 June 2012 03:46, Doug Barton <dougb@freebsd.org> wrote:
>>> I noticed a failure in one of my ports today while doing an upgrade, and
>>> was embarrassed to find that it was due to my port still using X11BASE.
>>> That led me to do a quick grep of the tree, which seems to indicate that
>>> there are a non-zero number of uses of it which seem to be erroneous:
>>
>> When the patch was committed a exp-run was done.
>
> Which isn't even close to being a thorough treatment. The *only* way to
> do this kind of work is with grep through the entire tree. That should
> have been done before the variable was removed.
It wasn't the only thing that was done.
> FWIW, there seem to be 3 categories of problems in ak's list. First, the
> variable isn't reached without an option being enabled (this is why
> exp-runs are not sufficient)
I thought we fixed all of these already.
> Second, the X11BASE was redundant, ala:
> -I${LOCALBASE}/include -I${X11BASE}/include
I fixed the ones I saw of these, but I wasn't too concerned about
getting them all.
> Third, it was just plain broken.
hm?
--
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkRyic4Mfp03sxVimBP6h8tdGH=unmE-xpZLDuAoCbWTg>