Date: Thu, 20 Sep 2012 20:37:19 +1200 From: Andrew Thompson <thompsa@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: net@freebsd.org Subject: Re: [CFT] if_transmit method for lagg(4) Message-ID: <CAFAOGNTE_HO4TScR0ztUihbs%2BfXeP6_jENvWTcnudK65J=1%2B-Q@mail.gmail.com> In-Reply-To: <20120920074730.GS85604@FreeBSD.org> References: <20120920074730.GS85604@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 20 September 2012 19:47, Gleb Smirnoff <glebius@freebsd.org> wrote:
> Hi,
>
> Yet another patch to test. Was suprising to me that lagg(4), which
> aims at high-performance, still utilizes if_start.
>
> Attached is patch that converts lagg(4) to use if_transmit. I'd
> appreciate if someone who do use lagg(4) tests the patch. If anyone
> benchmarks lagg(4) with and w/o patch that will be most appreciated.
Sean Bruno has already tested this patch at Yahoo, I have just been
delayed in committing it. There are just a few small differences so we
can commit one or merge.
Andrew
[-- Attachment #2 --]
Index: if_lagg.c
===================================================================
--- if_lagg.c (revision 238047)
+++ if_lagg.c (working copy)
@@ -110,7 +110,8 @@ static int lagg_ether_cmdmulti(struct lagg_port *,
static int lagg_setflag(struct lagg_port *, int, int,
int (*func)(struct ifnet *, int));
static int lagg_setflags(struct lagg_port *, int status);
-static void lagg_start(struct ifnet *);
+static int lagg_transmit(struct ifnet *ifp, struct mbuf *m);
+static void lagg_qflush(struct ifnet *ifp);
static int lagg_media_change(struct ifnet *);
static void lagg_media_status(struct ifnet *, struct ifmediareq *);
static struct lagg_port *lagg_link_active(struct lagg_softc *,
@@ -312,15 +313,12 @@ lagg_clone_create(struct if_clone *ifc, int unit,
if_initname(ifp, ifc->ifc_name, unit);
ifp->if_type = IFT_ETHER;
ifp->if_softc = sc;
- ifp->if_start = lagg_start;
+ ifp->if_transmit = lagg_transmit;
+ ifp->if_qflush = lagg_qflush;
ifp->if_init = lagg_init;
ifp->if_ioctl = lagg_ioctl;
ifp->if_flags = IFF_SIMPLEX | IFF_BROADCAST | IFF_MULTICAST;
- IFQ_SET_MAXLEN(&ifp->if_snd, ifqmaxlen);
- ifp->if_snd.ifq_drv_maxlen = ifqmaxlen;
- IFQ_SET_READY(&ifp->if_snd);
-
/*
* Attach as an ordinary ethernet device, childs will be attached
* as special device IFT_IEEE8023ADLAG.
@@ -1222,37 +1220,44 @@ lagg_setflags(struct lagg_port *lp, int status)
return (0);
}
-static void
-lagg_start(struct ifnet *ifp)
+static int
+lagg_transmit(struct ifnet *ifp, struct mbuf *m)
{
struct lagg_softc *sc = (struct lagg_softc *)ifp->if_softc;
- struct mbuf *m;
- int error = 0;
+ int error, len, mcast;
LAGG_RLOCK(sc);
/* We need a Tx algorithm and at least one port */
if (sc->sc_proto == LAGG_PROTO_NONE || sc->sc_count == 0) {
- IF_DRAIN(&ifp->if_snd);
+ m_freem(m);
LAGG_RUNLOCK(sc);
- return;
+ return (0);
}
- for (;; error = 0) {
- IFQ_DEQUEUE(&ifp->if_snd, m);
- if (m == NULL)
- break;
+ len = m->m_pkthdr.len;
+ mcast = (m->m_flags & (M_MCAST | M_BCAST)) ? 1 : 0;
+ ETHER_BPF_MTAP(ifp, m);
- ETHER_BPF_MTAP(ifp, m);
+ error = (*sc->sc_start)(sc, m);
+ if (error == 0) {
+ ifp->if_opackets++;
+ ifp->if_omcasts += mcast;
+ ifp->if_obytes += len;
+ } else
+ ifp->if_oerrors++;
+ LAGG_RUNLOCK(sc);
- error = (*sc->sc_start)(sc, m);
- if (error == 0)
- ifp->if_opackets++;
- else
- ifp->if_oerrors++;
- }
- LAGG_RUNLOCK(sc);
+ return (error);
}
+/*
+ * The ifp->if_qflush entry point for lagg(4) is a no-op.
+ */
+static void
+lagg_qflush(struct ifnet *ifp __unused)
+{
+}
+
static struct mbuf *
lagg_input(struct ifnet *ifp, struct mbuf *m)
{
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFAOGNTE_HO4TScR0ztUihbs%2BfXeP6_jENvWTcnudK65J=1%2B-Q>