Date: Thu, 22 Feb 2024 11:43:53 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: =?UTF-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= <einar@isnic.is> Cc: Gleb Popov <arrowd@freebsd.org>, ports@freebsd.org Subject: Re: Multiple new R ports Message-ID: <CAFDf7U%2BG2v5eQ2OJq76d2f3UGht9J1kTstFECAaqqnPPq5QUvA@mail.gmail.com> In-Reply-To: <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <CALH631nPt94VcQnsh5_CQHnGkb-5uVvRotFGWWoj4wRtNveXUQ@mail.gmail.com> <AD61A7F4-D5CC-487D-A08A-47267FD69052@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, I did take a look at review and noticed that TEST_DEPENDS are not used and that could means that test target works without any depends or ports are not tested at all. My curiosity is what do you think about the importance (or not) to have testunit feature working on R ports? I maintain a couple R ports and testunit revealed some errors that upstream fixed. Maybe this testunit subject could be apply to all ports that have that feat= ure. Thanks, Einar Bjarni Halld=C3=B3rsson <einar@isnic.is> escreveu (quinta, 22/02/2024 =C3=A0(s) 08:40): > > Hi, > > Could a committer take a look at https://reviews.freebsd.org/D43735 for m= e? > Adds 3 R modules, with dependencies, 13 new ports in total. > > Builds in poudriere and used in production. > > einar > > On 2/4/24 13:34, Einar Bjarni Halld=C3=B3rsson wrote: > >> On 3 Feb 2024, at 18:56, Gleb Popov <arrowd@freebsd.org> wrote: > >> > >> On Sat, Feb 3, 2024 at 6:31=E2=80=AFPM Einar Bjarni Halld=C3=B3rsson <= einar@isnic.is> wrote: > >>> Hi, > >>> > >>> I needed to create three new R ports, but with new ports for missing = dependencies, it=E2=80=99s 13 new ports in total, all R packages. > >>> > >>> Should I create one PR for them all, or one for each package with blo= ckers for dependencies? > >>> > >>> einar > >> Single PR should be fine. You may also consider creating a > >> Differential revision on our Phabricator. > >> > > Thanks. I created a revision in Phabricator for all the ports. We=E2=80= =99ll see how it goes. If needed, I can chop it up into multiple revisions. > > > > .einar > > > > --=20 Nuno Teixeira FreeBSD Committer (ports)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2BG2v5eQ2OJq76d2f3UGht9J1kTstFECAaqqnPPq5QUvA>