Date: Tue, 12 Nov 2024 09:23:20 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: gnome@freebsd.org, ashish@freebsd.org, dmgk@freebsd.org Subject: Re: Requiring SSE2 by default for i386 Message-ID: <CAFDf7UL0Uqtf=5pMif0rkqHS=5PF%2BcWppm5P0-i59JUURdtZCw@mail.gmail.com> In-Reply-To: <CAOtMX2gKMtFh5=OntRcaPP5taMRcs1-%2B5_HUKg6S60vBAMB3-w@mail.gmail.com> References: <CAOtMX2gua9NBY-_BB8rozaGvZJjg9tCkbM7XaWj5Q-fSKrM32w@mail.gmail.com> <CAFDf7UJ7XDKwQUg20WQkJCBf=ZF02dztrrKa=YQC0OycFa925Q@mail.gmail.com> <CAOtMX2j2rtpgp=yU1d-bzUSe3jq=UnxO8_O%2B4aHh6ORnMW_gdQ@mail.gmail.com> <CAFDf7UJ58-gE_KGM4tv3O78RWngQs-vHOxZMAKvn0d7yF6JNwA@mail.gmail.com> <CAOtMX2hzFy7_iVs0=voSm1cJfskEO4ezCJUGcKm6w7=4jewDxw@mail.gmail.com> <CAFDf7UJfHyNT2Rxh7wvByADOHE4ALu2ywMs8T5wfHpGei2tOEQ@mail.gmail.com> <CAOtMX2gKMtFh5=OntRcaPP5taMRcs1-%2B5_HUKg6S60vBAMB3-w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004a899b0626b3c5d0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, As upstream defaults to use SSE2 on amd64/i386 I'm reproducing it on port. I still don't get what this port has to do with rust SSE2 i386 requirement as it doesn't use rust code, but I think we will get some performance improvements. If you need any change on port, please feel free to change it. https://cgit.freebsd.org/ports/commit/?id=3D78b13cb9ecb8c0c0f59e09ba8d0264d= 023d6f688 Cheers, Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 =C3=A0(s) 2= 0:50): > Sounds good. > > On Mon, Nov 11, 2024 at 1:30=E2=80=AFPM Nuno Teixeira <eduardo@freebsd.or= g> wrote: > > > > Ah, sure. > > > > I will add OPTIONS_DEFAULT=3DSSE2 and check if it will be problems for > amd64 and aarch64. > > If everything ok then use this option since upstream default is SSE2 on > by default. > > > > Sorry as I misread past email. > > > > Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 =C3=A0(= s) > 16:25): > >> > >> I don't know what that "QMAKE_ON" part means. But when I do "make > >> config", it shows the SSE2 option disabled by default. > >> > >> On Mon, Nov 11, 2024 at 5:20=E2=80=AFAM Nuno Teixeira <eduardo@freebsd= .org> > wrote: > >> > > >> > (...) > >> > > >> > Just took a look at port Makefile and it's alleady set: > >> > > >> > OPTIONS_DEFINE=3D SSE2 > >> > SSE2_DESC=3D Enable SSE2 optimization > >> > SSE2_QMAKE_ON=3D CONFIG+=3Dsse2 > >> > SSE2_QMAKE_OFF=3D CONFIG+=3Dno-sse2 > >> > > >> > This port does not have rust code. > >> > > >> > Alan Somers <asomers@freebsd.org> escreveu (domingo, 10/11/2024 =C3= =A0(s) > 15:51): > >> >> > >> >> On Sun, Nov 10, 2024 at 7:00=E2=80=AFAM Nuno Teixeira <eduardo@free= bsd.org> > wrote: > >> >> > > >> >> > Hello, > >> >> > > >> >> >> graphics/fraqtive > >> >> > > >> >> > > >> >> > > https://github.com/mimecorg/fraqtive/blob/02914797f47d26c4098f4a3a945716b= 13998a8cc/INSTALL#L43 > >> >> > Upstream says SSE2 is enabled by default. > >> >> > > >> >> > What should we do here? > >> >> > >> >> Just set OPTIONS_DEFAULT_i386=3DSSE2 or OPTIONS_DEFAULT=3DSSE2 in t= he > port Makefile. > >> > > >> > > >> > > >> > -- > >> > Nuno Teixeira > >> > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org > > > > > > > > -- > > Nuno Teixeira > > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org > --=20 Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org --0000000000004a899b0626b3c5d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello,</div><div><br></div><div>As upstream defaults = to use SSE2 on amd64/i386 I'm reproducing it on port.<br></div><div>I s= till don't get what this port has to do with rust SSE2 i386 requirement= as it doesn't use rust code, but I think we will get some performance = improvements.<br></div><div><br></div><div>If you need any change on port, = please feel free to change it.<br></div><div><br></div><div><a href=3D"http= s://cgit.freebsd.org/ports/commit/?id=3D78b13cb9ecb8c0c0f59e09ba8d0264d023d= 6f688">https://cgit.freebsd.org/ports/commit/?id=3D78b13cb9ecb8c0c0f59e09ba= 8d0264d023d6f688</a></div><div><br></div><div>Cheers,<br></div></div><div d= ir=3D"ltr"><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class= =3D"gmail_attr">Alan Somers <<a href=3D"mailto:asomers@freebsd.org" targ= et=3D"_blank">asomers@freebsd.org</a>> escreveu (segunda, 11/11/2024 =C3= =A0(s) 20:50):<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0= px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">S= ounds good.<br> <br> On Mon, Nov 11, 2024 at 1:30=E2=80=AFPM Nuno Teixeira <<a href=3D"mailto= :eduardo@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>> wrote:<= br> ><br> > Ah, sure.<br> ><br> > I will add OPTIONS_DEFAULT=3DSSE2 and check if it will be problems for= amd64 and aarch64.<br> > If everything ok then use this option since upstream default is SSE2 o= n by default.<br> ><br> > Sorry as I misread past email.<br> ><br> > Alan Somers <<a href=3D"mailto:asomers@freebsd.org" target=3D"_blan= k">asomers@freebsd.org</a>> escreveu (segunda, 11/11/2024 =C3=A0(s) 16:2= 5):<br> >><br> >> I don't know what that "QMAKE_ON" part means.=C2=A0 = But when I do "make<br> >> config", it shows the SSE2 option disabled by default.<br> >><br> >> On Mon, Nov 11, 2024 at 5:20=E2=80=AFAM Nuno Teixeira <<a href= =3D"mailto:eduardo@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>&g= t; wrote:<br> >> ><br> >> > (...)<br> >> ><br> >> > Just took a look at port Makefile and it's alleady set:<b= r> >> ><br> >> > OPTIONS_DEFINE=3D SSE2<br> >> > SSE2_DESC=3D=C2=A0 =C2=A0 =C2=A0 Enable SSE2 optimization<br> >> > SSE2_QMAKE_ON=3D=C2=A0 CONFIG+=3Dsse2<br> >> > SSE2_QMAKE_OFF=3D CONFIG+=3Dno-sse2<br> >> ><br> >> > This port does not have rust code.<br> >> ><br> >> > Alan Somers <<a href=3D"mailto:asomers@freebsd.org" target= =3D"_blank">asomers@freebsd.org</a>> escreveu (domingo, 10/11/2024 =C3= =A0(s) 15:51):<br> >> >><br> >> >> On Sun, Nov 10, 2024 at 7:00=E2=80=AFAM Nuno Teixeira <= ;<a href=3D"mailto:eduardo@freebsd.org" target=3D"_blank">eduardo@freebsd.o= rg</a>> wrote:<br> >> >> ><br> >> >> > Hello,<br> >> >> ><br> >> >> >> graphics/fraqtive<br> >> >> ><br> >> >> ><br> >> >> > <a href=3D"https://github.com/mimecorg/fraqtive/blob= /02914797f47d26c4098f4a3a945716b13998a8cc/INSTALL#L43" rel=3D"noreferrer" t= arget=3D"_blank">https://github.com/mimecorg/fraqtive/blob/02914797f47d26c4= 098f4a3a945716b13998a8cc/INSTALL#L43</a><br> >> >> > Upstream says SSE2 is enabled by default.<br> >> >> ><br> >> >> > What should we do here?<br> >> >><br> >> >> Just set OPTIONS_DEFAULT_i386=3DSSE2 or OPTIONS_DEFAULT= =3DSSE2 in the port Makefile.<br> >> ><br> >> ><br> >> ><br> >> > --<br> >> > Nuno Teixeira<br> >> > FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0W= eb:=C2=A0 <a href=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_bla= nk">https://FreeBSD.org</a><br>; ><br> ><br> ><br> > --<br> > Nuno Teixeira<br> > FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0= <a href=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https= ://FreeBSD.org</a><br> </blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si= gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d= iv dir=3D"ltr"><div><font color=3D"#888888">Nuno Teixeira</font></div><div>= <div><font color=3D"#888888"> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a h= ref=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https://Fr= eeBSD.org</a><br></font></div></div></div></div> --0000000000004a899b0626b3c5d0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UL0Uqtf=5pMif0rkqHS=5PF%2BcWppm5P0-i59JUURdtZCw>