Date: Mon, 8 Sep 2014 10:23:27 -0400 From: Julio Merino <jmmv@freebsd.org> To: Alan Somers <asomers@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, "zfs-devel@freebsd.org" <zfs-devel@freebsd.org> Subject: Re: Introducing the ZFS test suite Message-ID: <CAFY7cWC_bMPwtLw%2Bfcinw7aedDP_JUpNOH4o3WyyDqfR6uWfcw@mail.gmail.com> In-Reply-To: <CAOtMX2i90%2BiKkoed3qBDBq4eMY-8VOtiAkqFb2Up-s%2BRGiit4A@mail.gmail.com> References: <CAOtMX2i90%2BiKkoed3qBDBq4eMY-8VOtiAkqFb2Up-s%2BRGiit4A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 25, 2014 at 2:38 PM, <asomers@gmail.com> wrote: > I just merged the ZFS test suite to projects/zfsd/head in change 270604. > [...] > The ZFS test suite still has some problems. Some of these are > blocking it from being merged to head: > * The atf-ksh93 hack. This is not a good thing to officially add to > ATF, but it would be a lot of work to convert the test programs to run > under sh. Especially because of the use of ksh arrays. As we discussed, agreed that this is a bit hackish, but I think this is a reasonable compromise and the hack is unlikely to break anytime soon. (Haven't looked at the specifics that were implemented though.) Therefore, I would personally not consider a "rewrite in sh" to be a blocker for merging into head. > Remember, don't run these tests on a production system. What's the plan for this? Are the tests somehow disabled by default so that a user running the full test suite is not tripped by this? Or will all the panics and deadlocks be fixed before merging to head? Thanks for doing this!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWC_bMPwtLw%2Bfcinw7aedDP_JUpNOH4o3WyyDqfR6uWfcw>