Date: Sun, 11 May 2014 18:50:39 -0700 From: Craig Rodrigues <rodrigc@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-current Current <freebsd-current@freebsd.org>, "jenkins-admin@freebsd.org" <jenkins-admin@freebsd.org> Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 Message-ID: <CAG=rPVdjYfnwNuzG8GS8iFP7=wtvNorBZDqPZkOuwDiJseoj0Q@mail.gmail.com> In-Reply-To: <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <CAG=rPVdHR29qMsvZVfVxBgoX4Jg7sXXWePZ9%2BvvyPOcLqL5R8A@mail.gmail.com> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <CAG=rPVd8JVLxV1pFUVWsZBX1OnFAEUU6MeBugO3JH7Yf0gSXnA@mail.gmail.com> <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> <CAG=rPVeR3yWsYfu-USFbbVoZB4Fua1V6hBnMgZF=%2BtiXFMq_dw@mail.gmail.com> <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 11, 2014 at 4:22 PM, Warner Losh <imp@bsdimp.com> wrote: > > > The only logic that can work is to test MAKESYSPATH and respect it if it = is defined, and use the relative path if not (since we don't require MAKESY= SPATH to be defined to do a out-of-tree module build, and could be built on= a system that isn't running the latest current). That is a legitimate patch. I've seen people make similar changes to the kernel makefiles an mk rules, specifically folks who import FreeBSD kernel source into their tree, but have the mk rules in a "non-standard" place. Thanks for applying this change. > > > Using JIRA to force it is rather an annoying use of JIRA since it makes = making JIRA happy hard to test and outside the normal work flow. Please use the correct terminology to avoid confusion. Jenkins is not the same as JIRA. -- Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVdjYfnwNuzG8GS8iFP7=wtvNorBZDqPZkOuwDiJseoj0Q>