Date: Mon, 2 Dec 2024 14:25:54 -0800 From: Mark Peek <mp@freebsd.org> To: Mario Marietto <marietto2008@gmail.com> Cc: Mark Peek <mp@freebsd.org>, =?UTF-8?Q?Corvin_K=C3=B6hne?= <c.koehne@beckhoff.com>, FreeBSD virtualization <freebsd-virtualization@freebsd.org> Subject: Re: Failed to emulate instruction sequence [ 41f646040874064c017d88eb144c89 ] at 0xbea5fcf9 Message-ID: <CAGGgMJd%2Box54CyDNk6SgQ29b=Rte=MzpRFbgzM%2BF=QWOV8nu=Q@mail.gmail.com> In-Reply-To: <CA%2B1FSigZV6GXurd5KmBwVS6LdbOpP1fLK5wEB7-ROAp%2Bz1axsA@mail.gmail.com> References: <CA%2B1FSijzwf6xHOv7-CfmdFPmxD46vFEdaJ4V6xy29G4BYEetWA@mail.gmail.com> <CAGGgMJemKNkEB87sHABECYrQT37tzPcF74o6dejAz4=nMApCBQ@mail.gmail.com> <CA%2B1FSigkus=xw6Y%2BQzD8hK9Dmkt6LR1hsY-U8V=yQ3yReTSL8g@mail.gmail.com> <CAGGgMJcVC33joaZ%2BdHsCBMHZ-hZPDt-9E8mL6Nvb=AdbVDQPqA@mail.gmail.com> <CA%2B1FSigZV6GXurd5KmBwVS6LdbOpP1fLK5wEB7-ROAp%2Bz1axsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Dec 2, 2024 at 1:35 PM Mario Marietto <marietto2008@gmail.com>
wrote:
> Yes,I have also exchanged the bhyve binary. Now I'm trying to apply your
> patch and then I will rebuild vmm.
> I see that your code is :
>
> [0xF6] = {
> /* XXX Group 3 extended opcode - not just TEST */
> .op_byte = 0xF6,
> .op_type = VIE_OP_TYPE_TEST,
> .op_flags = VIE_OP_F_IMM,
> },
>
> but it seems wrong. Shouldn't be .op_flags = VIE_OP_F_IMM8 ?
>
Yes, per the discussion in the bug report, that was the change I need to
make before submitting it for review. Please make that change in your copy.
And per email after this one, yes, that compilation of vmm.ko looks fine.
Mark
[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr">On Mon, Dec 2, 2024 at 1:35 PM Mario Marietto <<a href="mailto:marietto2008@gmail.com">marietto2008@gmail.com</a>> wrote:</div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Yes,I have also exchanged the bhyve binary. Now I'm trying to apply your patch and then I will rebuild vmm. <br></div><div>I see that your code is :<br></div><div><br></div><div>[0xF6] = {<br> /* XXX Group 3 extended opcode - not just TEST */<br> .op_byte = 0xF6,<br> .op_type = VIE_OP_TYPE_TEST,<br> .op_flags = VIE_OP_F_IMM,<br> },</div><div><br></div><div>but it seems wrong. Shouldn't be .op_flags = VIE_OP_F_IMM8 ?</div></div></blockquote><div><br></div><div>Yes, per the discussion in the bug report, that was the change I need to make before submitting it for review. Please make that change in your copy.</div><div><br></div><div>And per email after this one, yes, that compilation of vmm.ko looks fine.</div><div><br></div><div>Mark</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGGgMJd%2Box54CyDNk6SgQ29b=Rte=MzpRFbgzM%2BF=QWOV8nu=Q>