Date: Sun, 28 Oct 2012 12:13:46 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: Gabor Kovesdan <gabor@kovesdan.org>, freebsd-hackers@freebsd.org, Pedro Giffuni <pfg@freebsd.org>, hiren panchasara <hiren.panchasara@gmail.com> Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in Google Code-In 2012? You can help too!) Message-ID: <CAGH67wT-GO2a2n3RcXd0_TE%2BWDhJSwjvOst9vFrZJG5SNz0kFA@mail.gmail.com> In-Reply-To: <CAJ-VmomQVC-OfY7a%2B-tH0W9ekHGW6JidQ869Q6H94pTSk8xoKQ@mail.gmail.com> References: <CALCpEUHXkyPgqaypkiatx978jjMbiYtvMZC3nNHNpnRSdLf=PA@mail.gmail.com> <508D0F11.1060203@kovesdan.org> <CAJ-VmomQVC-OfY7a%2B-tH0W9ekHGW6JidQ869Q6H94pTSk8xoKQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 28, 2012 at 9:07 AM, Adrian Chadd <adrian@freebsd.org> wrote: > On 28 October 2012 03:55, Gabor Kovesdan <gabor@kovesdan.org> wrote: > >> Hi Hiren, >> >> good to hear that someone is working on this! However, porting these >> utilies is much tougher than it apparently seems. There are much more >> criteria than just it compiles and works. More specifically, you should >> make sure that: > > [snip] > > * It's totally bug compatible for now with gnu patch/diff. > * You write a _lot_ of test cases for the test framework, so people > can do automated regression testing on both performance and behaviour. > > It'd be nice to have more regression testing. :-) If you're looking for bug compatibility with GNU patch, I would start with the tests produced by upstream [1] as a base for determining how compatible BSD patch really is. Similar steps could and should have been done for BSD grep [2] (unfortunately GNU sort doesn't have any tests, but if we develop the guts (inputs and expected output) of some tests and commit them back to GNU, I'm sure they would appreciate it). Thanks, -Garrett 1. http://git.savannah.gnu.org/cgit/patch.git/tree/tests 2. http://git.savannah.gnu.org/cgit/grep.git/tree/tests
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wT-GO2a2n3RcXd0_TE%2BWDhJSwjvOst9vFrZJG5SNz0kFA>