Date: Mon, 31 Dec 2012 06:58:16 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: bf1783@gmail.com, freebsd-current@freebsd.org Subject: Re: svn commit: r244604 - head/usr.sbin/gssd Message-ID: <CAGH67wTswm=G73SUW2t_H0oJ20zoikDmAm%2B5dqye2rubQWwcFQ@mail.gmail.com> In-Reply-To: <1905046872.1604317.1356954929867.JavaMail.root@erie.cs.uoguelph.ca> References: <CAGH67wQLuOWd%2BZqh==b0XPA9haK%2BuMZM1W0%2B=XhjxgOpxo=yYQ@mail.gmail.com> <1905046872.1604317.1356954929867.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 31, 2012 at 3:55 AM, Rick Macklem <rmacklem@uoguelph.ca> wrote: ... > WITHOUT_KERBEROS is used other places, like telnetd. Were you aware of that? > (I just thought it would keep it consistent, but if you think it is better > to use a different name, I don't care.) Ah, no. I wasn't aware of that :). Given that something else has been standardized around the tree, I agree that your approach of using WITHOUT_KERBEROS is ok. I wasn't keen on the name just because it could have simplified the code using a positive instead of a negative predicate in the #ifdef. I looked at the updated patch and it looks good to me :). Thanks! -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTswm=G73SUW2t_H0oJ20zoikDmAm%2B5dqye2rubQWwcFQ>