Date: Wed, 30 Apr 2014 10:16:09 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: "Peel, Casey" <casey.peel@isilon.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, "bdrewery@FreeBSD.org" <bdrewery@freebsd.org> Subject: Re: Please provide process for small, targeted fixes in tools/regression Message-ID: <CAGHfRMAALMgFrGqQbRFpvRf9uCFQR-WH6uUS75GSn3VSE5_UBA@mail.gmail.com> In-Reply-To: <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com> References: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> <5F1D5D49-5F39-4EAC-89D5-E4D10FB3B01E@freebsd.org> <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 11, 2014 at 6:59 PM, Peel, Casey <casey.peel@isilon.com> wrote:
> Exellent, thanks Julio.
>
> Attached are 3 self-contained diffs, one per directory. Descriptions of the changes:
> * flock - .c changes to fix compiler errors; .t to wrap flock binary for integrating with prove
> * geom_mirror - gmirror won't let you remove the last partition in a mirror which all of these testcases do and thus fail (note that I've got these testcases plus other gmirror testcases already moved over to ATF and going through internal code reviews now, so maybe we just want to discard this)
> * kqueue - kqtest outputs files in TAP-consumable format, this is a .t file to run it through prove
>
> These were an intial salvo at getting existing tests working for our internal regression. I'm sure we'll be looking at others as well. If someone can just review the changes, I can get someone internally to commit them if necssary (although these will take more time to review than commit given how small they are).
The test drivers seem ok for TAP, but out of curiosity why are you
removing the geom remove testing in the geom_mirror testcases? Does
the test not work out of the box on vanilla FreeBSD?
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAALMgFrGqQbRFpvRf9uCFQR-WH6uUS75GSn3VSE5_UBA>