Date: Tue, 30 May 2017 21:27:22 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Alexander Morozov <alex@nixd.org> Cc: "freebsd-fs@freebsd.org" <freebsd-fs@freebsd.org> Subject: Re: VFS vn_lock function makes system unresponsive when calling vn_fullpath Message-ID: <CAGudoHGi5gjUERGm-HjMpYsp=M%2B44J0hdCcW1QhdQ40rnZM38Q@mail.gmail.com> In-Reply-To: <38666c423c33a5e1009c106c23aeb218@nixd.org> References: <38666c423c33a5e1009c106c23aeb218@nixd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 30, 2017 at 4:42 PM, Alexander Morozov <alex@nixd.org> wrote:
> Hi,
>
> At the moment I am developing a kernel module based on MAC Framework which
> is invoking a vn_fullpath() from vfs_cache.c.
>
> Here is the thing:
> When the MAC Framework mpo_vnode_check_write procedure is called, the
> kernel module is trying to retrieve: the path on the disk for the curthread
> and the path of the file in which the curthread is attempting to write. At
> the point when the program execution reaches the vn_fullpath() for the
> resolution of the file's path, the terminal window 'freezes' (actually the
> whole system is not responding, the rest ttys stop responding after
> entering login credentials).
>
> For instance, after loading and initializing a MAC kernel module, I am
> opening a existing text file using vi to edit it. After inserting some
> random text I press ESC key on keyboard and terminal window 'freezes' (at
> that moment the mpo_vnode_check_write is called) ( the struct vnode * vp
> which is passed to the MAC procedure is valid (not NULL) and type (enum
> vtype) is VREG).
>
> I have investigated this issue and found out the following:
> The get_fullpath() is calling the get_fullpath1() where later the
> vn_vptocnp() is invoked.
> Retrieving the location for the curthread is successful (the full path
> returned).
> But when the kernel module is making attempt to retrieve the path for the
> vp (argument of the mpo_vnode_check_write) the function vn_lock(*vp,
> LK_SHARED | LK_RETRY) (line 2191) located in function vn_vptocnp() is
> grabbing control forever.
>
Hard to say off hand, but so far it looks like the vnode is already
exclusively locked and now the kernel deadlocks itself by locking it in
shared mode. You can easily inspect the state in ddb with show lockedvnods.
Are you running the kernel with DEBUG_VFS_LOCKS?
What is the purpose of this module in the first place?
regular vnode -> path resolution is not guaranteed to work. While it will
work most of the time, it is inherently racy problematic in presence of
multiple hardlinks. For instance someone else can be modifying the
directory tree as you translate back and trick you into thinking the vnode
represents a different file. Even if this was not the case, the translation
of the sort on each write would be a performance killer.
The only possibly working approach I see would attach metadata to the vnode
after lookup and then use it.
> Below I have copied and pasted the code which performers the path
> resolution and the MAC procedure handler:
> static int
> rw_retreive_data(struct thread * td, struct vnode *dvp, char ** rpath,
> char ** curpath, struct sandbox_rule_app ** rule_ptr)
> {
>
[snip]
>
error = vn_fullpath(td, td->td_proc->p_textvp, curpath, &curfreepath);
>
[snip]
> }
>
> int sandbox_vnode_check_write(struct ucred *active_cred,
> struct
> ucred *file_cred,
> struct
> vnode *vp,
> struct
> label *vplabel)
> {
> IS_MODULE_INITED(0)
> ASSERT_NULL_R(vp, 0);
>
> struct sandbox_rule_app * rule_ptr = NULL;
> char * rpath = "-";
> char * curpath = "-";
> int error = 0;
>
> RWLOCK_BLOCK(&sandbox_rules_lock, RWLOCK_READ)
> {
>
> error = rw_retreive_data(curthread, vp, &rpath, &curpath,
> &rule_ptr);
>
If this is using rwlock the code is additionally wrong as vn_fullpath can
induce unbound sleep, while the lock at hand only supports bound sleep.
--
Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGi5gjUERGm-HjMpYsp=M%2B44J0hdCcW1QhdQ40rnZM38Q>