Date: Wed, 17 Dec 2014 23:27:40 +0100 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>, Allan Jude <allanjude@freebsd.org> Subject: Re: top -d1 behavior Message-ID: <CAGwOe2bvp-sa6tCgSUcSut8uWu5on7NOunOp26bL-d7PPfkuMg@mail.gmail.com> In-Reply-To: <201412161203.44257.jhb@freebsd.org> References: <CAGwOe2Zp2cHhCb%2Br_m5HZYJFyc=3DDsPEi7v_7ZVxJ0fkO1jEA@mail.gmail.com> <54723E7E.8080509@freebsd.org> <CAGwOe2amb-6%2BHHhkFOkgE7xk7HSNgAgf5o2S2p4Kw%2Btgigifnw@mail.gmail.com> <201412161203.44257.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 16, 2014 at 6:03 PM, John Baldwin <jhb@freebsd.org> wrote: > On Sunday, November 23, 2014 4:57:33 pm Fernando Apestegu=C3=ADa wrote: >> > Neither seem like what the user would expect. >> >> Agreed. But this is mostly unexpected (and can lead scripts to fail): > > Actually, I think having it output the states since boot would be more > consistent with other tools like iostat/vmstat/etc. They report states > on the first iteration that are states since boot. For example: > > % iostat 1 > tty ada0 ada1 cd0 = cpu > tin tout KB/t tps MB/s KB/t tps MB/s KB/t tps MB/s us ni sy in= id > 8 225 20.41 12 0.24 20.56 12 0.24 2.79 0 0.00 3 0 2 0= 95 > 0 6230 60.00 6 0.35 64.80 10 0.62 0.00 0 0.00 9 0 91 0= 0 > 0 6195 64.00 5 0.31 51.43 7 0.35 0.00 0 0.00 11 0 89 0= 1 > > Can you test this test patch to see if it gives you what you expect from > top -d1? Yes it does. I thought however that the discussion was over :) so I filed a PR[1] to at least warn in the man page about the special behavior for this case. I would rather fix top and leave the man page as it is. Cheers. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195717 > > Index: contrib/top/top.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- top.c (revision 275828) > +++ top.c (working copy) > @@ -176,7 +176,7 @@ char *argv[]; > int preset_argc =3D 0; > char **av; > int ac; > - char dostates =3D No; > + char dostates =3D Yes; > char do_unames =3D Yes; > char interactive =3D Maybe; > char warnings =3D 0; > > -- > John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2bvp-sa6tCgSUcSut8uWu5on7NOunOp26bL-d7PPfkuMg>