Date: Tue, 3 Jan 2012 20:24:33 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Stefan Bethke <stb@lassitu.de> Cc: freebsd-embedded@freebsd.org Subject: Re: dev/etherswitch Message-ID: <CAJ-VmonwDFJzReS%2BRE6umGK8XoFwPOt=FGFAyOhYtOvjzM7sCQ@mail.gmail.com> In-Reply-To: <CAJ-VmomL=v00uEN62V8NSFEoD9LcUg1KVW38HrXxT-gXnZoO4g@mail.gmail.com> References: <C456CF98-0E0D-4563-8FDB-B77B8CF5B9E1@lassitu.de> <CAJ-VmomL=v00uEN62V8NSFEoD9LcUg1KVW38HrXxT-gXnZoO4g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Take a look at: http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work/commit/b31c2bc80e8328924802b24682a9d5ea77b13ebf You have one commit messages but multiple things: * You've added 'pinon', which lets you set a default output value. I know at least one board required it for enabling USB power, why's the tplink need it? * Why'd you flip on bit 13 in the AR91xx GPIO function register? And comment out the USB led device? * You also changed the delay to three and commented it out. :-) Some of this may need to be thrown back in -HEAD. So, can you provide some more background info so I can see what needs to be merged back? :) Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonwDFJzReS%2BRE6umGK8XoFwPOt=FGFAyOhYtOvjzM7sCQ>