Date: Fri, 29 Jul 2016 08:44:50 -0700 From: Jim Harris <jim.harris@gmail.com> To: Borja Marcos <borjam@sarenet.es> Cc: FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Subject: Re: Intel NVMe troubles? Message-ID: <CAJP=Hc-3ogfoSZ0cjycm%2Bsb0M80B6M5ZrGtWn1BjfOFPteGgdA@mail.gmail.com> In-Reply-To: <AAC8E93B-F263-4B7E-91DF-9EAC77FB2C3C@sarenet.es> References: <CBC304D0-AA57-4EF5-A2DD-1888FB88DE12@sarenet.es> <CAJP=Hc-KdmScZtCRDcF=CTpNcMkn2brXiPx4XwJA0aTYgkxm%2Bg@mail.gmail.com> <AAC8E93B-F263-4B7E-91DF-9EAC77FB2C3C@sarenet.es>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a113ad34a8fabbe0538c82130 Content-Type: text/plain; charset=UTF-8 On Fri, Jul 29, 2016 at 1:10 AM, Borja Marcos <borjam@sarenet.es> wrote: > > > On 28 Jul 2016, at 19:25, Jim Harris <jim.harris@gmail.com> wrote: > > > > Yes, you should worry. > > > > Normally we could use the dump_debug sysctls to help debug this - these > > sysctls will dump the NVMe I/O submission and completion queues. But in > > this case the LBA data is in the payload, not the NVMe submission > entries, > > so dump_debug will not help as much as dumping the NVMe DSM payload > > directly. > > > > Could you try the attached patch and send output after recreating your > pool? > > Just in case the evil anti-spam ate my answer, sent the results to your > Gmail account. > > Thanks Borja. It looks like all of the TRIM commands are formatted properly. The failures do not happen until about 10 seconds after the last TRIM to each drive was submitted, and immediately before TRIMs start to the next drive, so I'm assuming the failures are for the the last few TRIM commands but cannot say for sure. Could you apply patch v2 (attached) which will dump the TRIM payload contents inline with the failure messages? Thanks, -Jim --001a113ad34a8fabbe0538c82130 Content-Type: application/octet-stream; name="delete_debug_v2.patch" Content-Disposition: attachment; filename="delete_debug_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ir7x08cv0 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvbnZtZS9udm1lX25zLmMgYi9zeXMvZGV2L252bWUvbnZtZV9u cy5jCmluZGV4IDc1NGQwNzQuLjI5M2RkMjUgMTAwNjQ0Ci0tLSBhL3N5cy9kZXYvbnZtZS9udm1l X25zLmMKKysrIGIvc3lzL2Rldi9udm1lL252bWVfbnMuYwpAQCAtNDYxLDYgKzQ2MSw3IEBAIG52 bWVfbnNfYmlvX3Byb2Nlc3Moc3RydWN0IG52bWVfbmFtZXNwYWNlICpucywgc3RydWN0IGJpbyAq YnAsCiAJCSAgICBicC0+YmlvX2Jjb3VudC9udm1lX25zX2dldF9zZWN0b3Jfc2l6ZShucyk7CiAJ CWRzbV9yYW5nZS0+c3RhcnRpbmdfbGJhID0KIAkJICAgIGJwLT5iaW9fb2Zmc2V0L252bWVfbnNf Z2V0X3NlY3Rvcl9zaXplKG5zKTsKKwkJbnZtZV9wcmludGYobnMtPmN0cmxyLCAibGVuZ3RoPSVq dSBsYmE9JWp1XG4iLCAodWludG1heF90KWRzbV9yYW5nZS0+bGVuZ3RoLCAodWludG1heF90KWRz bV9yYW5nZS0+c3RhcnRpbmdfbGJhKTsKIAkJYnAtPmJpb19kcml2ZXIyID0gZHNtX3JhbmdlOwog CQllcnIgPSBudm1lX25zX2NtZF9kZWFsbG9jYXRlKG5zLCBkc21fcmFuZ2UsIDEsCiAJCQludm1l X25zX2Jpb19kb25lLCBicCk7CmRpZmYgLS1naXQgYS9zeXMvZGV2L252bWUvbnZtZV9xcGFpci5j IGIvc3lzL2Rldi9udm1lL252bWVfcXBhaXIuYwppbmRleCA5MmZlNjcyLi42ZDM2ZDMzIDEwMDY0 NAotLS0gYS9zeXMvZGV2L252bWUvbnZtZV9xcGFpci5jCisrKyBiL3N5cy9kZXYvbnZtZS9udm1l X3FwYWlyLmMKQEAgLTMxOSw2ICszMTksMTMgQEAgbnZtZV9xcGFpcl9jb21wbGV0ZV90cmFja2Vy KHN0cnVjdCBudm1lX3FwYWlyICpxcGFpciwgc3RydWN0IG52bWVfdHJhY2tlciAqdHIsCiAKIAlp ZiAoZXJyb3IgJiYgcHJpbnRfb25fZXJyb3IpIHsKIAkJbnZtZV9xcGFpcl9wcmludF9jb21tYW5k KHFwYWlyLCAmcmVxLT5jbWQpOworCQlpZiAocXBhaXItPmlkID4gMCAmJiByZXEtPmNtZC5vcGMg PT0gTlZNRV9PUENfREFUQVNFVF9NQU5BR0VNRU5UKSB7CisJCQlzdHJ1Y3QgbnZtZV9kc21fcmFu Z2UgKmRzbV9yYW5nZTsKKworCQkJZHNtX3JhbmdlID0gcmVxLT51LnBheWxvYWQ7CisJCQludm1l X3ByaW50ZihxcGFpci0+Y3RybHIsICJ0cmltIGZhaWxlZDogbGVuPSVqdSBsYmE9JWp1XG4iLAor CQkJCSAgICAodWludG1heF90KWRzbV9yYW5nZS0+bGVuZ3RoLCAodWludG1heF90KWRzbV9yYW5n ZS0+c3RhcnRpbmdfbGJhKTsKKwkJfQogCQludm1lX3FwYWlyX3ByaW50X2NvbXBsZXRpb24ocXBh aXIsIGNwbCk7CiAJfQogCg== --001a113ad34a8fabbe0538c82130--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJP=Hc-3ogfoSZ0cjycm%2Bsb0M80B6M5ZrGtWn1BjfOFPteGgdA>