Date: Wed, 7 Sep 2011 14:02:43 +0800 From: Li-Wen Hsu <lwhsu@FreeBSD.org> To: Sofian Brabez <sbz@freebsd.org> Cc: FreeBSD Python Team <freebsd-python@freebsd.org> Subject: Re: Update of devel/py-twisted to 11.0.0 Message-ID: <CAKBkRUyaDNYUHW1B%2BkH-b3E9C298tGFMiYgVqPXR8dsXuiC_tQ@mail.gmail.com> In-Reply-To: <20110906205704.GA38513@freebsd.ifr.lan> References: <20110906205704.GA38513@freebsd.ifr.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Sofian,
Thanks for working on this, python@ definitely need more power!
Please see the reply inline.
On Wed, Sep 7, 2011 at 04:57, Sofian Brabez <sbz@freebsd.org> wrote:
> Hi python@,
>
> This afternoon, I've merged my initial update to the twisted related ports with
> the patch of lwhsu@ [1]. My patch is there [2].
>
> My patch make happy portlint, add LICENSE in each twisted ports and add new
> OPTIONS for twistedPair port.
And please also add pair_DEPENDS in bsd.python.mk, that is around line 641.
> Please lwhsu@ notice than all twisted ports are sharing the
> ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the @dirrm
> by a @dirrmtry in pkg-plist.
Thanks for reminding me this, I think we have
@dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in
in devel/py-twistedCore/pkg-plist, and all other twisted ports depends
on twistedCore, so we probably don't need to have @dirrm nor @dirrmtry
in other ports.
They sneaked in my patch because I forget this, so just removing them
is fine. (I was planning getting maintainer's approval on general idea
then doing a more substantial patch.)
Using @dirrmtry is fine, too.
> I would like to have your approbation to commit it, and sent it to my mentors
> for their approbations, I start working on this one because I took the pr
> ports/155570 but lwhsu@ inform me about ports/159954 on #freebsd-python.
>
> Below the tinderbox build logs:
>
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=7-sbz&search_port_name=twisted&Go=Go
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=8-sbz&search_port_name=twisted&Go=Go
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=9-sbz&search_port_name=twisted&Go=Go
All looks good, and I also tested building all other ports depends on
twisted, all are fine. Is anybody aware non-backward-compatible
change?
Another thing, I found there is no twisted 11.0.0 distfiles in
http://tmrc.mit.edu/mirror/twisted/, that's why I removed them from
MASTER_SITES, could you check it again?
Please consider my suggestions, thanks!
> Regards
>
> [1] http://people.freebsd.org/~lwhsu/twisted-11.0.0.diff
> [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff
>
> --
> Sofian Brabez
>
--
Li-Wen Hsu
http://lwhsu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyaDNYUHW1B%2BkH-b3E9C298tGFMiYgVqPXR8dsXuiC_tQ>