Date: Thu, 19 Nov 2015 16:42:50 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Sean Bruno <sbruno@freebsd.org> Subject: Re: sys/modules "make clean" seems broken again Message-ID: <CANCZdfo7etDZZtU6EPNQxUDaOSgJ_9ra6STfJWd4c3q77p7fhg@mail.gmail.com> In-Reply-To: <3514235.7QMnNNElsE@ralph.baldwin.cx> References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin <jhb@freebsd.org> wrote: > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: > > I thought I fixed this a year or two ago, but now a "make clean" in > > sys/modules seems to leave bus_if.h device_if.h and pci_if.h in the > > directory. > > > > Should I just add these to the clean targets? > > Blame Warner as his MFILES changes broke this. In particular, see r287263 > which turned off cleaning these up. I'm not sure what that broke that > caused it to be disabled. > > Your change is a gross hack though. > Yes. The reason I had to break it was that there were a few files named _if.c and _if.h in the tree that would get deleted when make clean was run in the modules. I'll take another run at fixing this. Sean's "fix" is a horrible hack. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo7etDZZtU6EPNQxUDaOSgJ_9ra6STfJWd4c3q77p7fhg>