Date: Thu, 28 Sep 2017 10:49:11 -0600 From: Warner Losh <imp@bsdimp.com> To: Andriy Gapon <avg@freebsd.org> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: lua in zfs Message-ID: <CANCZdfrZo6EDXYSwLr5R6h8vrWcuxJTgQUKryFO84TVH=-5cNw@mail.gmail.com> In-Reply-To: <64f6d438-e985-9262-2b1d-1e4b017b7691@FreeBSD.org> References: <ae7a34af-4c91-daae-e917-b98ac7fb69d9@FreeBSD.org> <CANCZdfqocwEArqntzUdwBufxa%2BNANHs6VdKJrRFwGHT8HpaFyw@mail.gmail.com> <fd8098c7-37dd-e66a-e528-2668203381a5@FreeBSD.org> <CANCZdfp7=_SyD4SovOFuA1hq8cQHOy%2BGQ8EbtnDZ5LnFNQuE8Q@mail.gmail.com> <64f6d438-e985-9262-2b1d-1e4b017b7691@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 28, 2017 at 10:42 AM, Andriy Gapon <avg@freebsd.org> wrote: > On 28/09/2017 18:40, Warner Losh wrote: > > > > > > On Thu, Sep 28, 2017 at 9:16 AM, Andriy Gapon <avg@freebsd.org > > <mailto:avg@freebsd.org>> wrote: > > > > On 28/09/2017 16:13, Warner Losh wrote: > > > Which version? Where in the tree? Can this be disabled? > > > > It's lua 5.2.4 at the moment. Its source code will reside in > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua. At run-time it > will be in > > zfs.ko or in kernel if it's built with ZFS option. For time being, > it's not > > possible to turn it off individually, but if you don't include ZFS > or any CDDL > > licensed code at all, then you won't have Lua too. But I think that > it should > > be possible to add a new knob specifically to compile ZFS without > Lua, if > > anybody wants it. > > > > > > OK. Any chance you could put it in sys/contrib/lua instead? The same > place that > > the boot loader lua project has it? The lua boot loader project is using > 5.3.0 > > it seems, is there any reason you couldn't use that instead? > > I don't really know. I am just importing an upstream ZFS commit, because > without it we are getting more and more out of sync. I don't know if the > ZFS > Lua has any special customizations, etc. I don't want to spend a lot of > time on > investigating that and fighting with any possible quirks. If the > consolidation > of Lua-s is possible and practical, then I hope that someone will do it. > > Of course, there is another option which is not to import any Lua at all > right > now and to stub out all calls into Lua-dependent routines with ENOTSUP. > In that > case we will have plenty of time to work on importing a perfect Lua. On > the > other hand, switching from one Lua to another and doing svn rm is not hard > either. I'm happy to work with you on this. I'd like to get lua bootloader into the tree, and this gives me motivation to finish it up, even if it is a bit rough around the edges... What's your timeline for bringing this stuff in? Warner > > > I've been working on this in the background and was hoping to get it in > before 12. > > > > > On Thu, Sep 28, 2017 at 5:40 AM, Andriy Gapon <avg@freebsd.org > > <mailto:avg@freebsd.org>> wrote: > > > > > >> > > >> I am going to import the upstream ZFS Channel Programs change > that adds Lua > > >> interpreter to ZFS kernel code. In addition to pure Lua (no > libraries) it > > >> also > > >> has a number of functions to interact with ZFS. No general > purpose kernel > > >> access. > > > -- > Andriy Gapon >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrZo6EDXYSwLr5R6h8vrWcuxJTgQUKryFO84TVH=-5cNw>