Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jan 2023 09:58:55 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Dmitry Salychev <dsl@mcusim.org>
Cc:        Kurt Jaeger <pi@freebsd.org>, Stephane Rochoy <stephane.rochoy@stormshield.eu>,  freebsd-current@freebsd.org
Subject:   Re: Tooling Integration and Developer Experience
Message-ID:  <CANCZdfrpx9MW0wE0oWnkk5LmqbMVVaC_2z5fzaidK4QnRG2eTg@mail.gmail.com>
In-Reply-To: <86zga0nf1q.fsf@peasant.tower.home>
References:  <202301300254.30U2sm0k061914@dell.no.berklix.net> <97020cad-f913-2985-2093-e4c23bf671e3@antonovs.family> <86357sxsly.fsf@cthulhu.stephaner.labo.int> <Y9eepV%2B%2Bch6qMBta@home.opsec.eu> <86edrcp13z.fsf@peasant.tower.home> <CANCZdfp7RpYyGH1-yx-ddaibwM3=sfYOYw8m7mKjJ4gfWjUW6Q@mail.gmail.com> <86zga0nf1q.fsf@peasant.tower.home>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000f630c05f37e22b5
Content-Type: text/plain; charset="UTF-8"

I think just "sys/dev/dpaa2" is all you need when adding the Herald rule. :)

More generally, no, there's no way that I've found to only match files that
match certain regexp.

Warner

On Mon, Jan 30, 2023 at 9:49 AM Dmitry Salychev <dsl@mcusim.org> wrote:

>
> Warner Losh <imp@bsdimp.com> writes:
>
> > On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev <dsl@mcusim.org> wrote:
> >
> >  Hi,
> >
> >  Kurt Jaeger <pi@freebsd.org> writes:
> >
> >  > Hi,
> >  >
> >  >> > On 1/30/23 02:54, Julian H. Stacey wrote:
> >  >> >    The main idea: to prevent information fragmentation and
> improve
> >  >> >    discoverability, cross-referencing abilities, search, etc.
> >  >>
> >  >> With regards to improving discoverability, Phabricator's Owner
> >  >> tool could be a good tactical move: it allow to bind code area to
> >  >> peoples in order to automatically add them to reviews.
> >  >
> >  > If you know phabricator in more detail, is there any kind of tool
> >  > to understand the activity going on ?
> >  >
> >  > In bugs.freebsd.org, there is the dashboard:
> >  >
> >  > https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html
> >  >
> >  > I think we might need something similar to help us understand
> >  > the current state of the phabricator instance and the work
> >  > being done.
> >  >
> >  > Phab allows Dashboards, but no-one had the time to configure some
> >  > queries to provide relevant stats.
> >
> >  I'd prefer to have an automatic note via email from Phabricator if any
> >  file with my copyright was modified/patched/improved in a newly opened
> >  review.
> >
> >  I don't think that people tend to ignore changes to those parts of code
> >  they've written (or touched at least).
> >
> > You can easily create a herald rule to do this. I have one for all of
> src, but others have subsets
> > like the boot loader. And anybody with an account can do that.
> >
> > Warner
>
> Looks really useful, thanks for a hint. Is there any way to test regexp
> matching for files content? Btw, there could be a carefully selected set
> of pre-defined Herald rules added to any new committer's account.
>
> --
> Dmitry Salychev
>

--0000000000000f630c05f37e22b5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I think just &quot;sys/dev/dpaa2&quot; is all you need whe=
n adding the Herald rule. :)<div><br></div><div>More generally, no, there&#=
39;s no way that I&#39;ve found to only match files that match certain rege=
xp.</div><div><br></div><div>Warner</div></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 30, 2023 at 9:49 AM Dm=
itry Salychev &lt;<a href=3D"mailto:dsl@mcusim.org">dsl@mcusim.org</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Warner Losh &lt;<a href=3D"mailto:imp@bsdimp.com" target=3D"_blank">imp@bsd=
imp.com</a>&gt; writes:<br>
<br>
&gt; On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev &lt;<a href=3D"mailto:=
dsl@mcusim.org" target=3D"_blank">dsl@mcusim.org</a>&gt; wrote:<br>
&gt;<br>
&gt;=C2=A0 Hi,<br>
&gt;<br>
&gt;=C2=A0 Kurt Jaeger &lt;<a href=3D"mailto:pi@freebsd.org" target=3D"_bla=
nk">pi@freebsd.org</a>&gt; writes:<br>
&gt;<br>
&gt;=C2=A0 &gt; Hi,<br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt;&gt; &gt; On 1/30/23 02:54, Julian H. Stacey wrote:<br>
&gt;=C2=A0 &gt;&gt; &gt;=C2=A0 =C2=A0 The main idea: to prevent information=
 fragmentation and=C2=A0 =C2=A0 improve<br>
&gt;=C2=A0 &gt;&gt; &gt;=C2=A0 =C2=A0 discoverability, cross-referencing ab=
ilities, search, etc.<br>
&gt;=C2=A0 &gt;&gt; <br>
&gt;=C2=A0 &gt;&gt; With regards to improving discoverability, Phabricator&=
#39;s Owner<br>
&gt;=C2=A0 &gt;&gt; tool could be a good tactical move: it allow to bind co=
de area to<br>
&gt;=C2=A0 &gt;&gt; peoples in order to automatically add them to reviews.<=
br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt; If you know phabricator in more detail, is there any kind o=
f tool<br>
&gt;=C2=A0 &gt; to understand the activity going on ?<br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt; In <a href=3D"http://bugs.freebsd.org" rel=3D"noreferrer" t=
arget=3D"_blank">bugs.freebsd.org</a>, there is the dashboard:<br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt; <a href=3D"https://bugs.freebsd.org/bugzilla/page.cgi?id=3D=
dashboard.html" rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.o=
rg/bugzilla/page.cgi?id=3Ddashboard.html</a><br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt; I think we might need something similar to help us understa=
nd<br>
&gt;=C2=A0 &gt; the current state of the phabricator instance and the work<=
br>
&gt;=C2=A0 &gt; being done.<br>
&gt;=C2=A0 &gt;<br>
&gt;=C2=A0 &gt; Phab allows Dashboards, but no-one had the time to configur=
e some<br>
&gt;=C2=A0 &gt; queries to provide relevant stats.<br>
&gt;<br>
&gt;=C2=A0 I&#39;d prefer to have an automatic note via email from Phabrica=
tor if any<br>
&gt;=C2=A0 file with my copyright was modified/patched/improved in a newly =
opened<br>
&gt;=C2=A0 review.<br>
&gt;<br>
&gt;=C2=A0 I don&#39;t think that people tend to ignore changes to those pa=
rts of code<br>
&gt;=C2=A0 they&#39;ve written (or touched at least).<br>
&gt;<br>
&gt; You can easily create a herald rule to do this. I have one for all of =
src, but others have subsets<br>
&gt; like the boot loader. And anybody with an account can do that.<br>
&gt;<br>
&gt; Warner<br>
<br>
Looks really useful, thanks for a hint. Is there any way to test regexp<br>
matching for files content? Btw, there could be a carefully selected set<br=
>
of pre-defined Herald rules added to any new committer&#39;s account.<br>
<br>
-- <br>
Dmitry Salychev<br>
</blockquote></div>

--0000000000000f630c05f37e22b5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrpx9MW0wE0oWnkk5LmqbMVVaC_2z5fzaidK4QnRG2eTg>