Date: Thu, 27 Dec 2012 00:12:53 +0200 From: George Liaskos <geo.liaskos@gmail.com> To: Jan Beich <jbeich@tormail.org> Cc: freebsd-chromium@freebsd.org Subject: Re: openat, O_DIRECTORY, shell_integration_linux.cc Message-ID: <CANcjpOBHzHjigiwesgzz9MFwss9hPTE133WDK7J3YRSDid_idw@mail.gmail.com> In-Reply-To: <1Tns6P-000IsX-DH@internal.tormail.org> References: <1Tns6P-000IsX-DH@internal.tormail.org>
next in thread | previous in thread | raw e-mail | index | archive | help
No, this patch is already removed actually. The next major update will include many patch cleanups, clang build also got fixed. https://github.com/gliaskos/freebsd-chromium/tree/beta Regards, On Wed, Dec 26, 2012 at 4:38 PM, Jan Beich <jbeich@tormail.org> wrote: > Are there issues when using openat() et al. on FreeBSD 8.0 and forward? > > Index: www/chromium/files/patch-chrome__browser__shell_integration_linux.cc > =================================================================== > --- www/chromium/files/patch-chrome__browser__shell_integration_linux.cc (revision 309498) > +++ www/chromium/files/patch-chrome__browser__shell_integration_linux.cc (working copy) > @@ -4,7 +4,7 @@ > if (!PathService::Get(chrome::DIR_USER_DESKTOP, &desktop_path)) > return false; > > -+#if !defined(OS_FREEBSD) > ++#ifdef O_DIRECTORY > +// BSD: Linux-specific calls like openat are used so defined out for BSD. > int desktop_fd = open(desktop_path.value().c_str(), O_RDONLY | O_DIRECTORY); > if (desktop_fd < 0) > _______________________________________________ > freebsd-chromium@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-chromium > To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANcjpOBHzHjigiwesgzz9MFwss9hPTE133WDK7J3YRSDid_idw>