Date: Mon, 13 Apr 2015 14:20:03 +0000 From: Ben Woods <woodsb02@gmail.com> To: Piotr Robert Konopelko <piotr.konopelko@moosefs.com> Cc: FreeBSD Ports <ports@freebsd.org>, Jakub Kruszona-Zawadzki <jakub.kruszona@moosefs.com>, MooseFS Technical Support Department <dwt@moosefs.com>, =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> Subject: Re: MooseFS Ports for versions 2.0 and 3.0 Message-ID: <CAOc73CBrQ-4X2Hhc19CEOcY8K2f06X7EFLGxpuo2V39ZooGaHA@mail.gmail.com> In-Reply-To: <3504531.pypRB0Rknn@hp> References: <2694094.4JmStLgM3m@hp> <CAGwOe2asg1F8xKcSa5hk4P2hzdB_Ai=4ZootT8-zLLv583kW8w@mail.gmail.com> <CAOc73CCqqUQs2b4t4tYX__Sgx%2BaLM3qeZHxAtzxiurEaNzUR1A@mail.gmail.com> <3504531.pypRB0Rknn@hp>
next in thread | previous in thread | raw e-mail | index | archive | help
Nice work putting the ports together - its a good first effort! I have a
few comments about the format of the ports and bug reports - sorry there
are quite a few. I don't mean to be picky, but I wanted to minimise the
back-and-forth for you to get these committed.
1. Updates to existing ports should be attached as patches to the current
ports tree. The easiest way to do this if you got the ports tree from
subversion (not portsnap) is using the svn diff command. Tick the "patch"
option when attaching so we can see a nice pretty diff from within bugzilla=
.
2. New ports should be attached as a shar(1) file. Assuming the port is
called oneko, cd to the directory above where the oneko directory is
located, and then type: shar `find oneko` > oneko.shar
3. It's nice for ports for share parts of their configuration, but I don't
think it should be called "bsd.port.moosefs.mk" (this implies it is part of
the port build scripts). A good example of what you could do
is devel/libtool. It has a Makefile which includes Makefile.common. The
devel/libltdl port also includes "${.CURDIR}/../libtool/Makefile.common".
4. @dirrm is now deprecated in pkg-plist. Suggest it is probably easier to
build this with "make install && make makeplist > pkg-plist". Note that you
should check the plist looks correct, and also delete the top warning line
from the generated file.
5. The pkg-descr file should be updated to include a better description of
the package, and link to the website.
6. Before submitting a port, check that it passes the normal checks by
installing the ports-mgmt/portlint program, and running "portlint -AC" in
the port directory.
7. If you have access to a poudriere installation, you should submit the
"poudriere testport" logs showing that this port will build successfully.
Myself or other ports contributors/committers can help with this if you do
not have access to a poudriere installation, but please make sure you have
at least tested the build on FreeBSD with a "make install".
Much of this is covered in the porter's handbook. It's a good read if you
haven't already seen it. You can find it here:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html
Note that if you re-submit patches to each bug report, be sure to tick the
option that it obsolete's the previous patch.
Good luck! :)
Regards,
Ben
On Mon, Apr 13, 2015 at 7:05 PM Piotr Robert Konopelko <
piotr.konopelko@moosefs.com> wrote:
> Thank you very much for this information.
>
>
>
> I posted requests to the FreeBSD bugzilla:
>
>
>
>
> https://bugs.freebsd.org/bugzilla/buglist.cgi?quicksearch=3Dmoosefs&list_=
id=3D56910
>
>
>
>
>
> --
>
> Best regards,
>
> Piotr Robert Konopelko
>
> MooseFS Technical Support Engineer | moosefs.com
>
>
>
>
> On Thursday 09 of April 2015 2:52:32 PM Ben Woods wrote:
>
> Those ports currently have their maintainer fields set to "
> ports@freebsd.org", meaning there is no maintainer.
>
> When you submit the bug report and attach your patch to update the port,
> simply ensure the maintainer email address is updated to your own. You wi=
ll
> then be volunteering as the maintainer for those ports.
>
> Regards,
> Ben
>
> On Thu, 9 Apr 2015 at 9:12 pm Fernando Apestegu=C3=ADa <
> fernando.apesteguia@gmail.com> wrote:
>
> El 09/04/2015 15:00, "Piotr Robert Konopelko" <piotr.konopelko@moosefs.co=
m
> >
> escribi=C3=B3:
> >
> > Dear FreeBSD Ports team,
> >
> > On FreeBSD Ports site only ports for MooseFS 1.6.27-5 are available:
> > https://www.freebsd.org/cgi/ports.cgi?query=3Dmoosefs&stype=3Dall[1]
> >
> > Longer than a half year ago MooseFS 2.0 has been released and few days
> ago - MooseFS
> > 3.0.
> >
> > We would like to inform, that we have prepared ports for MooseFS versio=
ns
> 2.0 and 3.0.
> >
> > How is the way to upgrade them in FreeBSD ports tree?
>
> You can start here:
>
> https://bugs.freebsd.org/bugzilla/
>
> And file a request
>
> > Is there a possibility to make our team the maintainer of the MooseFS
> FreeBSD Ports?
>
> Since ports@ is the current maintainer, you could file another request an=
d
> see if they are willing to drop mantainership in your favor or ask here :=
)
>
> >
> >
> > --
> > Best regards,
> > Piotr Robert Konopelko
> > *MooseFS Technical Support Engineer* | moosefs.com[2]
> >
> >
> > --------
> > [1] https://www.freebsd.org/cgi/ports.cgi?query=3Dmoosefs&stype=3Dall
> > [2] http://moosefs.com
> > _______________________________________________
> > freebsd-ports@freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org=
"
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
>
>
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOc73CBrQ-4X2Hhc19CEOcY8K2f06X7EFLGxpuo2V39ZooGaHA>