Date: Tue, 5 Jul 2011 15:36:02 +0200 From: Robert Millan <rmh@debian.org> To: Dimitry Andric <dim@freebsd.org> Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: [PATCH] __FreeBSD_cc_version in <sys/cdefs.h> Message-ID: <CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw@mail.gmail.com> In-Reply-To: <4E12E358.80002@FreeBSD.org> References: <CAOfDtXMHdVm%2B7DFr=ZV4x_5uQ=q%2B2A0cFxvZsUgGzqWEwURhYg@mail.gmail.com> <4E12E358.80002@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] 2011/7/5 Dimitry Andric <dim@freebsd.org>: > As far as I can see, this code only gives warnings when compiled with > gcc 4.5 or higher, and when using the -Wundef flag. Isn't it easier to > just remove the -Wundef flag here? Here's a patch to remove -Wundef. I think it's a bad idea however, IMHO it's better to fix the cause of the warning instead. -- Robert Millan [-- Attachment #2 --] Index: sys/conf/kern.mk =================================================================== --- sys/conf/kern.mk (revision 223736) +++ sys/conf/kern.mk (working copy) @@ -5,7 +5,7 @@ # CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ - -Wundef -Wno-pointer-sign -fformat-extensions \ + -Wno-pointer-sign -fformat-extensions \ -Wmissing-include-dirs -fdiagnostics-show-option # # The following flags are next up for working on:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw>