Date: Tue, 9 Jul 2013 16:47:46 +0200 From: Robert Millan <rmh@freebsd.org> To: Jeremy Chadwick <jdc@koitsu.org> Cc: freebsd-fs@freebsd.org Subject: Re: Compatibility options for mount(8) Message-ID: <CAOfDtXNxT%2BhnS8n%2BOY6a7n=6UiwgDJo6M3GZx48JgskRKoY=gg@mail.gmail.com> In-Reply-To: <20130702000732.GA72587@icarus.home.lan> References: <CAOfDtXM_KJeLLUcsFA0EZOC8ZgSjKiLKuGeeNPQKCcZwcaJbCQ@mail.gmail.com> <20130702000732.GA72587@icarus.home.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Jeremy,
2013/7/2 Jeremy Chadwick <jdc@koitsu.org>:
> On Tue, Jul 02, 2013 at 01:11:52AM +0200, Robert Millan wrote:
> Minor but are well-justified given quality of code:
>
> 1. Put "n" in alphabetical order/after "l" and not at the end of the
> getopt() string, i.e.:
>
> while ((ch = getopt(argc, argv, "adF:fLlno:prt:uvw")) != -1)
Will do. Thanks for the correction.
> 2. Please use strncmp(). I know other parts of the same code use strcmp()
> and those should really be improved at some other time, but while you're
> already there you might as well use strncmp() (you'll see others have
> done the same), i.e.:
>
> } else if (strncmp(p, "remount", 7) == 0) {
What is the rationale behind this?
> 3. mount(8) man page should reflect these (IMO). Attached is the diff
> for that; wording based off of some other man pages.
Thank you.
--
Robert Millan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXNxT%2BhnS8n%2BOY6a7n=6UiwgDJo6M3GZx48JgskRKoY=gg>