Date: Fri, 6 Dec 2019 15:49:46 -0700 From: Adam Weinberger <adamw@adamw.org> To: sgk@troutmask.apl.washington.edu Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: python36 is still broken. Message-ID: <CAP7rwcj00Z81VBJ47dFfn1RUJFCb1rBAW77pP7Wj=BxRdZFp6g@mail.gmail.com> In-Reply-To: <20191206184050.GA44417@troutmask.apl.washington.edu> References: <20191206184050.GA44417@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 6, 2019 at 11:41 AM Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
>
> This has been reported for many years and there are open bug reports.
> Any chance that the this will be fixed.
>
>
> --- work/Python-3.6.9/Modules/mathmodule.c.orig 2019-12-06 10:33:39.232673000 -0800
> +++ work/Python-3.6.9/Modules/mathmodule.c 2019-12-06 10:34:53.288616000 -0800
> @@ -67,7 +67,7 @@
> static const double logpi = 1.144729885849400174143427351353058711647;
>
> static double
> -sinpi(double x)
> +a_really_bad_idea_sinpi(double x)
> {
> double y, r;
> int n;
> @@ -296,7 +296,7 @@
> integer. */
> if (absx > 200.0) {
> if (x < 0.0) {
> - return 0.0/sinpi(x);
> + return 0.0/a_really_bad_idea_sinpi(x);
> }
> else {
> errno = ERANGE;
Hi Steve,
WIthout context it's hard to advise. What PRs with that patch exist?
Have they been responded to or have they been ignored? Team immunity
from PR timeouts no longer exists, so if the problem needs a fix let's
fix it.
# Adam
--
Adam Weinberger
adamw@adamw.org
https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcj00Z81VBJ47dFfn1RUJFCb1rBAW77pP7Wj=BxRdZFp6g>