Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Nov 2017 22:52:10 +0000
From:      Khilan Gudka <Khilan.Gudka@cl.cam.ac.uk>
To:        freebsd-mips@freebsd.org
Subject:   fabs(-0.0) returns -0.0
Message-ID:  <CAPJvC9X2T23qZhWra8J__Fuo6000nxb-w61q5=i%2BBHmpXfmdmA@mail.gmail.com>

next in thread | raw e-mail | index | archive | help
Hi,

The implementation of fabs(3) for MIPS (at least) appears to not be giving
the right answer for when -0 is passed, as it returns -0 instead of +0. The
implementation of fabs is:

double fabs(double x) {
  if (x < 0)
    return -x;
  return x;
}

The if-test fails for -0 and thus it is returned. Is this a known issue? A
simple fix would be to return x+0.0 instead of just x.

The implication of this is that other functions which rely on fabs, such as
hypot, also return -0. For example, hypot(-0.0, 0.0) returns -0 instead of
+0.

Thanks,
Khilan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPJvC9X2T23qZhWra8J__Fuo6000nxb-w61q5=i%2BBHmpXfmdmA>