Date: Tue, 18 Nov 2025 08:27:21 -0500 From: Ed Maste <emaste@freebsd.org> To: Mark Millard <marklmi@yahoo.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: FYI: getopt in /usr/src/contrib/diff/lib/getopt.h vs. /usr/obj/usr/src/arm64.aarch64/tmp/usr/include/unistd.h : reported as incompatible with future C23 use Message-ID: <CAPyFy2CzY%2BiK4Xx-ouBBR4z%2B2DBbctq6zjpMYmVs%2BAU2OTs9fA@mail.gmail.com> In-Reply-To: <B5362682-0A91-4213-890F-E3C4CFA04911@yahoo.com> References: <B5362682-0A91-4213-890F-E3C4CFA04911.ref@yahoo.com> <B5362682-0A91-4213-890F-E3C4CFA04911@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 8 Nov 2025 at 11:10, Mark Millard <marklmi@yahoo.com> wrote: > > In file included from /usr/src/contrib/diff/src/diff3.c:32: > /usr/src/contrib/diff/lib/getopt.h:154:12: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C23, conflicting with a previous declaration [-Wdeprecated-non-prototype] > 154 | extern int getopt (); > | ^ > /usr/obj/usr/src/arm64.aarch64/tmp/usr/include/unistd.h:384:6: note: conflicting prototype is here > 384 | int getopt(int, char * const [], const char *); > | ^ I think we can just remove contrib/diff/lib/getopt.h and use the system header. I've opened a review to do that in https://reviews.freebsd.org/D53802
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CzY%2BiK4Xx-ouBBR4z%2B2DBbctq6zjpMYmVs%2BAU2OTs9fA>