Date: Wed, 14 Jun 2023 11:05:31 +0100 From: Alexander Chernikov <melifaro@FreeBSD.org> To: garyj@gmx.de Cc: current@freebsd.org Subject: Re: ifconfig dumps core and gdb uses an undefined symbol Message-ID: <D4A8FF85-D145-4205-B7D2-DE2F43DA7F42@FreeBSD.org> In-Reply-To: <20230614115350.5e7386fa@ernst.home> References: <20230614095956.26234554@ernst.home> <7A98AD66-35D3-447B-B808-2A52E9AD28F3@FreeBSD.org> <20230614110135.15b928db@ernst.home> <20230614115350.5e7386fa@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D8DFF943-15F9-4B45-B131-186AEC58725F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
> On 14 Jun 2023, at 10:53, Gary Jennejohn <garyj@gmx.de> wrote:
>=20
> On Wed, 14 Jun 2023 09:01:35 +0000
> Gary Jennejohn <garyj@gmx.de <mailto:garyj@gmx.de>> wrote:
>=20
>> On Wed, 14 Jun 2023 09:09:04 +0100
>> Alexander Chernikov <melifaro@FreeBSD.org> wrote:
>>=20
>>>> On 14 Jun 2023, at 08:59, Gary Jennejohn <garyj@gmx.de> wrote:
>>> Hi Gary,
>>>>=20
>>>> So, now I have a new problem with current.
>>>>=20
>>>> I just now updated my current sources and ran buildworld and =
buildkernel,
>>>> since Gleb fixed the WITHOUT_PF problem.
>>>>=20
>>>> After installing the new world and kernel I see that ifconfig is =
dumping
>>>> a core, apparently when it tries to show lo0, since re0 is =
correctly
>>>> shown:
>>>>=20
>>>> ifconfig
>>>> re0: flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 =
mtu 4088 =
options=3D82098<VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
>>>> ether redacted
>>>> inet 192.168.178.XXX netmask 0xffffff00 broadcast =
192.168.178.255
>>>> Segmentation fault (core dumped)
>>> Could you please try to narrow down the crashing command? e.g.
>>> Ifconfig lo0
>>> Ifconfig lo0 net
>>> Ifconfig lo0 inet6
>>> Could you try to rebuild ifconfig w/o netlink (e.g. set =
WITHOUT_NETLINK=3Dyes in the make.conf & make -C sbin/ifconfig clean all =
install) and see if the new binary works?
>>>=20
>>=20
>> I already have WITHOUT_NETLINK=3Dyes in my /etc/src.conf.
>>=20
>> I didn't install ifconfig. I simply started it from the build =
directory.
>>=20
>> ifconfig lo0 shows the settings for lo0 and then dumps core.
>>=20
>=20
> After your most recent changes "ifconfig re0" and "ifconfg lo0" don't
> result in any errors. But "ifconfig" alone still results in a core
> dump, which per gdb is happening in the strlcpy() call at =
in_status_tunnel()
> in af_inet.c.
Indeed.
diff --git a/sbin/ifconfig/ifconfig.c b/sbin/ifconfig/ifconfig.c
index d30d3e1909ae..6a80ad5763b2 100644
--- a/sbin/ifconfig/ifconfig.c
+++ b/sbin/ifconfig/ifconfig.c
@@ -822,6 +822,7 @@ list_interfaces_ioctl(if_ctx *ctx)
continue;
if (!group_member(ifa->ifa_name, args->matchgroup, =
args->nogroup))
continue;
+ ctx->ifname =3D cp;
/*
* Are we just listing the interfaces?
*/
Does this one fix the crash?
>=20
> --
> Gary Jennejohn
--Apple-Mail=_D8DFF943-15F9-4B45-B131-186AEC58725F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=us-ascii
<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><br><blockquote type=3D"cite"><div>On 14 =
Jun 2023, at 10:53, Gary Jennejohn <garyj@gmx.de> wrote:</div><br =
class=3D"Apple-interchange-newline"><div><meta charset=3D"UTF-8"><span =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; =
display: inline !important;">On Wed, 14 Jun 2023 09:01:35 =
+0000</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none; float: none; display: inline !important;">Gary Jennejohn =
<</span><a href=3D"mailto:garyj@gmx.de" style=3D"font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; orphans: auto; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: =
0px;">garyj@gmx.de</a><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;">> =
wrote:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"><blockquote type=3D"cite" style=3D"font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;">On Wed, 14 Jun 2023 09:09:04 +0100<br>Alexander =
Chernikov <melifaro@FreeBSD.org> wrote:<br><br><blockquote =
type=3D"cite"><blockquote type=3D"cite">On 14 Jun 2023, at 08:59, Gary =
Jennejohn <garyj@gmx.de> wrote:<br></blockquote>Hi =
Gary,<br><blockquote type=3D"cite"><br>So, now I have a new problem with =
current.<br><br>I just now updated my current sources and ran buildworld =
and buildkernel,<br>since Gleb fixed the WITHOUT_PF =
problem.<br><br>After installing the new world and kernel I see that =
ifconfig is dumping<br>a core, apparently when it tries to show lo0, =
since re0 is correctly<br>shown:<br><br>ifconfig<br>re0: =
flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu =
4088 =
options=3D82098<VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE=
><br> ether =
redacted<br> inet 192.168.178.XXX netmask =
0xffffff00 broadcast 192.168.178.255<br>Segmentation fault (core =
dumped)<br></blockquote>Could you please try to narrow down the crashing =
command? e.g.<br>Ifconfig lo0<br>Ifconfig lo0 net<br>Ifconfig lo0 =
inet6<br>Could you try to rebuild ifconfig w/o netlink (e.g. set =
WITHOUT_NETLINK=3Dyes in the make.conf & make -C sbin/ifconfig clean =
all install) and see if the new binary works?<br><br></blockquote><br>I =
already have WITHOUT_NETLINK=3Dyes in my /etc/src.conf.<br><br>I didn't =
install ifconfig. I simply started it from the build =
directory.<br><br>ifconfig lo0 shows the settings for lo0 and then dumps =
core.<br><br></blockquote><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;">After =
your most recent changes "ifconfig re0" and "ifconfg lo0" =
don't</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none; float: none; display: inline !important;">result in any errors. =
But "ifconfig" alone still results in a core</span><br =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none;"><span =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; =
display: inline !important;">dump, which per gdb is happening in the =
strlcpy() call at in_status_tunnel()</span><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;">in =
af_inet.c.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"></div></blockquote>Indeed.</div><div><br><div><div>diff --git =
a/sbin/ifconfig/ifconfig.c b/sbin/ifconfig/ifconfig.c</div><div>index =
d30d3e1909ae..6a80ad5763b2 100644</div><div>--- =
a/sbin/ifconfig/ifconfig.c</div><div>+++ =
b/sbin/ifconfig/ifconfig.c</div><div>@@ -822,6 +822,7 @@ =
list_interfaces_ioctl(if_ctx *ctx)</div><div> =
=
continue;</div><div> =
if (!group_member(ifa->ifa_name, args->matchgroup, =
args->nogroup))</div><div> =
continue;</div><div>+ =
ctx->ifname =3D =
cp;</div><div> =
/*</div><div> =
* Are we just listing the interfaces?</div><div> =
=
*/</div></div><div><br></div><div>Does this one fix the =
crash?</div><blockquote type=3D"cite"><div><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline =
!important;">--</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;">Gary =
Jennejohn</span></div></blockquote></div><br></body></html>=
--Apple-Mail=_D8DFF943-15F9-4B45-B131-186AEC58725F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4A8FF85-D145-4205-B7D2-DE2F43DA7F42>