Date: Tue, 07 Jan 1997 13:16:11 -0700 From: Warner Losh <imp@village.org> To: asami@cs.berkeley.edu (Satoshi Asami) Cc: ports@freebsd.org Subject: Re: OpenBSD support in bsd.port.mk Message-ID: <E0vhhwR-0000iz-00@rover.village.org> In-Reply-To: Your message of "Sat, 04 Jan 1997 04:45:42 PST." <199701041245.EAA06777@baloon.mimi.com> References: <199701041245.EAA06777@baloon.mimi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199701041245.EAA06777@baloon.mimi.com> Satoshi Asami writes:
: Sorry for being late. Here's a diff from the -current version based
: on our recent discussion. There shouldn't be any change of
: functionality for FreeBSD.
Not a problem. I've been busy with other things.
: For the directory orderings, I generally went from "root/system" to
: "usr/user". I didn't put back the NOMANCOMPRESS, you need to tell me
: how it works in OpenBSD first (is it a positive logic with
: MANCOMPRESS?).
OK. I'll check into this more. I've been flailing a lot lately with
the job hunt
The patches, as posted, look good. I have a few more that I'm
reviewing from the OpenBSD people right now. If you could commit
these patches (I've kept a copy in case you haven't :-), then I'll go
ahead and send out the next batch. They are much smaller, but at
least one of them needs some explaination from the source of the
patches before I commit it.
One that is trivial and easy is the following patch. Some systems
have shells that don't grok the !( syntax w/o an extra space between
the ! and the ( (pdksh I'm told). This space should present no
problem for other systems, so this should be a safe change.
Index: bsd.port.mk
===================================================================
RCS file: /home/imp/FreeBSD/CVS/src/share/mk/bsd.port.mk,v
retrieving revision 1.243
diff -u -r1.243 bsd.port.mk
--- bsd.port.mk 1996/12/26 01:02:29 1.243
+++ bsd.port.mk 1997/01/07 20:11:49
@@ -814,7 +814,7 @@
@${MKDIR} ${WRKDIR}
.endif
@for file in ${EXTRACT_ONLY}; do \
- if !(cd ${WRKDIR} && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${_DISTDIR}/$$file ${EXTRACT_AFTER_ARGS});\
+ if ! (cd ${WRKDIR} && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${_DISTDIR}/$$file ${EXTRACT_AFTER_ARGS});\
then \
exit 1; \
fi \
Warner
Available for work Resume: http://www.village.org/villagers/imp/mwlres.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E0vhhwR-0000iz-00>