Date: Fri, 30 Dec 2016 21:40:27 +0200 From: Toomas Soome <tsoome@me.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: "O. Hartmann" <ohartmann@walstatt.org>, FreeBSD CURRENT <freebsd-current@freebsd.org>, Toomas Soome <tsoome@FreeBSD.org> Subject: Re: r 310850: buildworld failure due to: nandfs.c:1049:15: error: too many arguments to function call, Message-ID: <F2CCA263-F1A7-410A-902D-3AEC4A23E9A7@me.com> In-Reply-To: <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org> References: <20161230202338.73e7d00b@thor.walstatt.dynvpn.de> <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 30. dets 2016, at 21:35, Dimitry Andric <dim@FreeBSD.org> wrote: >=20 > On 30 Dec 2016, at 20:23, O. Hartmann <ohartmann@walstatt.org> wrote: >>=20 >> Recent update of CURRENT to 2310850 fails with buildworld error: >>=20 >> [...] >> =3D=3D=3D> lib/atf/libatf-c++ (all) >> --- all_subdir_lib/libstand --- >> --- nandfs.o --- >> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to = function call, >> expected 6, have 7 buffer, NULL); >> ^~~~ >> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded = from macro 'NULL' >> #define NULL ((void *)0) >> ^~~~~~~~~~~ >> 1 error generated. >> *** [nandfs.o] Error code 1 >=20 > This looks like the culprit to me: >=20 > On 30 Dec 2016, at 20:06, Toomas Soome <tsoome@FreeBSD.org> wrote: >> Author: tsoome >> Date: Fri Dec 30 19:06:29 2016 >> New Revision: 310850 >> URL: https://svnweb.freebsd.org/changeset/base/310850 >>=20 >> Log: >> dosfs support in libstand is broken since r298230 >>=20 >> Apparently the libstand dosfs optimization is a bit too optimistic >> and did introduce possible memory corruption. >>=20 >> This patch is backing out the bad part and since this results in >> dosfs reading full blocks now, we can also remove extra offset = argument >> from dv_strategy callback. >>=20 >> The analysis of the issue and the backout patch is provided by = Mikhail Kupchik. >>=20 >> PR: 214423 >> Submitted by: Mikhail Kupchik >> Reported by: Mikhail Kupchik >> Reviewed by: bapt, allanjude >> Approved by: allanjude (mentor) >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D864 >=20 > For some reason, your build seems to pick up an older stand.h header? >=20 > -Dimitry >=20 oh, apparently I *still* did miss one strategy call in nandfs.. Sorry, = I=E2=80=99ll try to fix it asap. rgds, toomas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F2CCA263-F1A7-410A-902D-3AEC4A23E9A7>