Date: Sun, 29 Dec 2019 01:34:28 -0500 From: "Garance A Drosehn" <drosih@rpi.edu> To: "Steve Kargl" <sgk@troutmask.apl.washington.edu> Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <FD587443-FFA6-486B-B63A-11F425227FF8@rpi.edu> In-Reply-To: <20191229051035.GA68947@troutmask.apl.washington.edu> References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 Dec 2019, at 0:10, Steve Kargl wrote: > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: >> >> What if the user wants to factor a hexadecimal value which does not >> happen to include [a...f]? >> >> How about recognizing a prefix of '0x' as a way to indicate the value >> is hexadecimal? > > An interested user will need to add that support. AFAIK, factor(6) > has never recognized the 0x prefix, and I'm not trying to add new > features. I'm simply fixing factor(6) to match its documentation, > and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > same results where applicable. Well, I'd be willing to do the work to add the new feature, and also make the commit. It'd be a nice easy task for me to tackle... :) But I think documenting that "hex works, but only for hex values which have at least one A-F in the value" is not something that I'd want to draw attention to via documentation. -- Garance Alistair Drosehn = drosih@rpi.edu or gad@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FD587443-FFA6-486B-B63A-11F425227FF8>