Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Apr 1997 13:14:18 +0100 (BST)
From:      Doug Rabson <dfr@nlsystems.com>
To:        Peter Dufault <dufault@hda.com>
Cc:        current@freebsd.org
Subject:   Re: Breaking the lkm DISPATCH macro
Message-ID:  <Pine.BSF.3.95q.970405131343.8538E-100000@herring.nlsystems.com>
In-Reply-To: <199704051006.FAA08421@hda.hda.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Apr 1997, Peter Dufault wrote:

> Heads up:
> 
> I'm about to break LKM's DISPATCH macro by passing in the name
> argument.  LKM's are broken in -current for MOD_DEV, and in fixing
> them I want to eliminate the static _module structure by prepending
> the name.
> 
> This can't be done compatably (without cruft like feature test macros)
> since DISPATCH uses _module directly and the new MOD_DECL functions
> will prepend the name.
> 
> The interface change will require changing DISPATCH to
> MOD_DISPATCH (gratuitous for consistency with the other macros)
> and passing the name in.  I'm keeping a DISPATCH macro there to
> generate an error that leads back to the header to see what changed.
> 
> I've fixed the code in the tree but user LKMs in -current will break.
> They're already broken in -current versus non -current since the name
> argument has changed from a string to an identifier so I think that
> is a minor issue.

Does this mean that my OSS module will stop working?  Sigh..

--
Doug Rabson				Mail:  dfr@nlsystems.com
Nonlinear Systems Ltd.			Phone: +44 181 951 1891




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95q.970405131343.8538E-100000>