Date: Fri, 2 Jul 1999 22:36:40 -0400 (EDT) From: "Brian F. Feldman" <green@unixhelp.org> To: Matthew Jacob <mjacob@feral.com> Cc: Greg Lehey <grog@lemis.com>, current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <Pine.BSF.4.10.9907022235340.12249-100000@janus.syracuse.net> In-Reply-To: <Pine.BSF.4.05.9907021731310.356-100000@semuta.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2 Jul 1999, Matthew Jacob wrote:
>
>
> Let me add to this:
> > opinion:
> >
> > If it's really blocking folks because things don't compile, it is always
> > acceptable to do what you need to do- the tree should always compile even
> > if -current. If the system doesn't boot because of change, then that's an
> > obvious one too. If things work differently or not as well, but things
> > are more or less working, it's not an emergency, so leave it for the
> > author to fix....
>
> ...always modulo a short delay (call it a couple of hours) after reporting
> the problem... after all, you don't *know* that the update isn't finished
> and that other things are coming down the pipe... but a couple of hours
> leaves really the most reasonable time for an integration to complete and
> the author to have had lunch in between.
>
I worded my original post wrong; my change did fix world. Your second point
(the "wait and see" approach) wouldn't apply in this case: Greg was asleep,
and world was broken.
Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___
green@FreeBSD.org _ __ ___ | _ ) __| \
FreeBSD: The Power to Serve! _ __ | _ \._ \ |) |
http://www.FreeBSD.org/ _ |___/___/___/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9907022235340.12249-100000>