Date: Sun, 20 Aug 2000 17:06:27 +0100 (BST) From: Nick Hibma <n_hibma@qubesoft.com> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pcic i82365.c Message-ID: <Pine.BSF.4.20.0008201646001.42769-100000@henny.webweaving.org> In-Reply-To: <200008190501.WAA77674@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Are you sure this does not hide some more obscure bug?
device_delete_child iterates through the device's children first with
device_delete_child(child, grandchild), detaches the device and then
actually deletes the device. The change you have made below simply
iterates through all the children and detaches them, after which it
calls delete on all of them.
The only real difference with the old version is that any child being
deleted was detached and then deleted before its siblings were detached.
I have a gut feeling that you are looking at a problem with
interdependencies between the children during detach and not a problem
during detach.
Nick
> imp 2000/08/18 22:01:08 PDT
>
> Modified files:
> sys/dev/pcic i82365.c
> Log:
> Call bus_generic_detach on pcic before deleting the children. This
> has the side effect of detaching the children before I delete them.
> When I put the last commits in a loop for loop it died after 5 or so
> iterations. After this change, I lasted 50 before I stopped the test.
>
> Revision Changes Path
> 1.24 +5 -2 src/sys/dev/pcic/i82365.c
>
>
--
Qube Software, Ltd. Private:
n_hibma@qubesoft.com n_hibma@webweaving.org
n_hibma@freebsd.org
http://www.qubesoft.com/ http://www.etla.net/~n_hibma/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.20.0008201646001.42769-100000>