Date: Sat, 15 Jan 2000 13:55:52 -0500 (EST) From: "Matthew N. Dodd" <winter@jurai.net> To: Greg Lehey <grog@lemis.com> Cc: "Matthew N. Dodd" <mdodd@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: How often to commit? (was: cvs commit: src/sys/i386/isa if_ex.c) Message-ID: <Pine.BSF.4.21.0001151352220.462-100000@sasami.jurai.net> In-Reply-To: <20000115130818.G349@mojave.worldwide.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Jan 2000, Greg Lehey wrote: > When I see messages like this, all containing relatively small > modifications, I wonder if we should come to some agreement on how > often a commit should be made for modules on which we're actively > working. I'm not picking on mdodd (well, only in the sense that I > noticed these three commits); I'm just wondering. I tend to go to the > other extreme myself, testing changes in some detail before making a > mega-commit. I suspect that the truth lies somewhere between these > two extremes. Would anybody like to discuss where it might be? In the first commit I fixed the driver so it would work. I broke it back when I blindly converted it to newbus; my tester went away and I didn't get any real feedback. Since I now have a card I can fix and test myself. In the second commit I implemented new functionality. In the third I did some commetic cleanups. I've been fussed at for doing one big commit before and I've been burned before by doing massive changes (if_ep). So, if you're just using me as an example to start a conversation thats fine, but be aware that this specific case is a really bad example. :) -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | This Space For Rent | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0001151352220.462-100000>