Date: Mon, 18 Sep 2000 23:47:49 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Warner Losh <imp@village.org> Cc: sanpei@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Please review: small change in sys/i386/isa/clock.c and sys/alpha/alpha/clock.c for PC-Card melody beep code. Message-ID: <Pine.BSF.4.21.0009182338210.16890-100000@besplex.bde.org> In-Reply-To: <200009171838.MAA24081@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 17 Sep 2000, Warner Losh wrote: > I've seen these patches many times and think that it is a good idea. > This interface needs to be exported so that the pccard system sounds > don't interfere with normal systme sounds. It needs locking changes to be exportable: 1) splhigh()/splx(), at least in RELENG_4 where there is no giant lock and spl*() has a non-null effect, so that callers don't need to know that it must be called at splsoftclock() or higher. 2) Honor the current locking protocol acquire_timer2()/release_timer2() -- don't do anything if (!beeping). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009182338210.16890-100000>