Date: Mon, 30 Apr 2001 17:40:00 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mark Murray <mark@grondar.za> Cc: smp@FreeBSD.ORG Subject: Re: sys/mutex.h sys/lock.h (and other) cleanups. Commit Candidate #2 Message-ID: <Pine.BSF.4.21.0104301719340.24661-100000@besplex.bde.org> In-Reply-To: <200104300643.f3U6hIp31951@gratis.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 30 Apr 2001, Mark Murray wrote: > Said Bruce Evans <bde@zeta.org.au>: > > Actually, the deprecation consists of including <sys/lockmgr.h> instead > > of <sys/lock.h> in some headers that only need the former. <sys/lock.h> > > is not such a header, but it still includes <sys/lockmgr.h> although this > > is more bogus than before. The verbose comment before this include has > > been copied to to many places (more than 0). This says that the bogus include ing <sys/lockmgr.h> in <sys/lock.h> is not new; it is just more bogus than before [since part (most?) of the work to remove it has been done]. > Previously said BDE: > > The mess for <sys/lock.h> is much older and messier than for <sys/mutex.h>. > > Now, <sys/lock.h> is sort of an extension of <sys/mutex.h>, but most places > > that include it are for its (intentional) side effect of including the > > old lock interface, <sys/lockmgr.h>. The old lock interface will be going > > away, so we shouldn't move the include of <sys/lockmgr.h> to *.c. OTOH, > > the entanglement of <sys/lock*.h> makes it difficult to include > > <sys/lock.h> in the right places (if any). I think the next step should > > be to include <sys/lockmgr.h> instead of <sys/lock.h> in *.h. > > I'm confused. Does sys/lockmgr.h go into sys/lock.h for its intentional > side effects or not? Not when the next step is completed. The intentional side effect was mostly to pollute other headers that include <sys/lock.h> with <sys/lockmgr.h> also. I don't want to hold up the commit any more waiting for this. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0104301719340.24661-100000>