Date: Fri, 20 Sep 2002 12:36:50 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Darren Reed <darrenr@reed.wattle.id.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <Pine.BSF.4.21.0209201236320.16925-100000@InterJet.elischer.org> In-Reply-To: <XFMail.20020920114059.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Sep 2002, John Baldwin wrote: > > On 20-Sep-2002 Darren Reed wrote: > > btw, I think m_length() as a function which does something besides return > > the length of an mbuf is wrong. I think that kind of task is better delt > > with by keeping a pointer to the last mbuf in the chain. I'd recommend > > that m_length() do what it suggests it do and have another one, m_lastbuf() > > or something to do that job. Well, no, needing m_lastbuf() just sucks > > bigtime. Some thought to making m_length() a M_LENGTH() might be an idea > > too (that thought crossed my mind elsewhere), but that'd only fit well if > > mbufs were fixed up with a tail pointer. > > FWIW, I agree with this. If the function name needs to be changed to > make it more intuitive, so be it. There is nothing intuitive about > a function named foo_length() not returning the length of 'foo'. > m_iterate() > -- > > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0209201236320.16925-100000>