Date: Thu, 16 Jan 2003 15:47:24 -0800 (PST) From: Nate Lawson <nate@root.org> To: Sam Leffler <sam@errno.com> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h Message-ID: <Pine.BSF.4.21.0301161546050.47824-100000@root.org> In-Reply-To: <20e801c2bdad$770d56f0$5a557f42@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Jan 2003, Sam Leffler wrote: > > >> Modified files: > > >> sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h > > >> Log: > > >> Improve memory allocation. > > >> - Don't use contigmalloc() and allocate page by page to avoid > > >> allocation failure. > > >> - allocate buffer by PAGE_SIZE. > > > > > > Some comments. > > > > > >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > > >> - OHCI_SIDSIZE, M_DEVBUF); > > >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > > > malloced buffers are not guaranteed to be accessable by a device. > > Use bus dma instead. > > New drivers should use bus_dma. I recently hit an issue like this with > jumbo mbufs not being handled by the bge driver because it doesn't use bus > dma. Valid points. I just wanted to clarify that many of his mallocs are not for buffers addressed by dma but also for control/header structures. Those do not need to be changed. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0301161546050.47824-100000>