Date: Wed, 22 Aug 2001 20:35:23 -0400 (EDT) From: Mike Silbersack <silby@silby.com> To: Dave Zarzycki <zarzycki@freebsd.org> Cc: <freebsd-net@freebsd.org> Subject: Re: RFC: SACK/FACK patch port to Current Message-ID: <Pine.BSF.4.30.0108222028520.14763-100000@niwun.pair.com> In-Reply-To: <Pine.LNX.4.33.0108221713240.16888-200000@bonk.apple.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Aug 2001, Dave Zarzycki wrote: > Attached and tested. > > I'd like to merge this in unless anybody objects. > > davez > > -- > Dave Zarzycki I haven't done any testing of this code, but having SACK support would certainly be nice, so I think committing it to -current with the intention of a long testing period before mfcing is a good idea. However, before that is done, I think some changes should be made; all the #ifdef SACK and #ifdef FACKs are ugly. They should be taken out, and runtime tuneables (defaulting to on) should be added around the pieces of code that actually control SACK and FACK initialization at socket setup time. This will ensure that it gets wide testing, and at the same time will allow people who suspect that it is causing problems to still turn it off. Once those changes are made, it's probably best to have 2-3 other committers test and review before committing. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.30.0108222028520.14763-100000>