Date: Sun, 27 Jun 2004 17:29:23 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: FreeBSD current users <current@freebsd.org> Subject: Re: jail getfsstat patches. Message-ID: <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net> In-Reply-To: <20040627160959.GL12007@darkness.comp.waw.pl> References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org> <20040627101951.GJ12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net> <20040627160959.GL12007@darkness.comp.waw.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 27 Jun 2004, Pawel Jakub Dawidek wrote: > IMHO it should stay as it is, because: ok. some more points while skipping through the code a second time: * could we make this strlcpy(sp->f_mntonname, "<restricted>", s.th. w/o '<' and '>' ? [] or () would make me feel better as those though special characters won't redirect anything in sh even if we should never see this. * in fhstatfs you missed a prison_enforce_statfs call * some spelling/grammer left to someone else else looks good to me; didn't check the compat code; going to see if I can build a kernel and setup some jails on a test machine to see if it works as well. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.53.0406271706340.89503>