Date: Thu, 20 Aug 1998 19:10:56 -0400 (EDT) From: Tim Vanderhoek <hoek@hwcn.org> To: Satoshi Asami <asami@FreeBSD.ORG> Cc: obrien@NUXI.com, ports@FreeBSD.ORG, hoek@FreeBSD.ORG Subject: Re: cvs commit: ports/lang/glibstdc++28 Makefile Message-ID: <Pine.GSO.3.96.980820183017.14347B-100000@james.hwcn.org> In-Reply-To: <199808192353.QAA03197@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 19 Aug 1998, Satoshi Asami wrote:
> +.if !target(generate-plist)
> +generate-plist:
> + @if [ ! -f ${PLIST} -o ! -f ${COMMENT} -o ! -f ${DESCR} ]; then ${ECHO} "** Missing package files for ${PKGNAME}."; exit 1; fi
I'm not sure this is quite right. For example, the ilu port
creates its whole PLIST in the post-install target. To make the
port work with the current bsd.port.mk, I added
TMPPLIST= ${PLIST}
Which won't work with the new change.
I think just keeping the test in fake-pkg: is enough, although I
do have patches that change "generate-plist:" to "${TMPPLIST}:"
and make fake-pkg depend on "${TMPPLIST}". This is kinda cool
and also should solve the problem (although writing
generate-plist target that forces plist generation iff TMPPLIST
and PLIST refer to different files was tricky).
Other than that, only a little (but unfortunately lengthy)
comment on your original message with patches... :)
[From a now dead message :]
> One thing we can easily add is to substitute stuff in DESCR. Things
> like PREFIX come to mind. I'm not sure if it's worth the complication
> though.
I'm not sure this is a good idea...
That would make, eg. http://www.FreeBSD.ORG/ports have problems.
The general idea is worthwhile. For example, it would be nice if
the apache+php+msql+foobaz+legal.zip binary package could include
a description of itself saying "This package is for the `legal'
papersize.".
However, I don't think we're quite at the point where we need to
cross that bridge, yet. :-)
It probably would be useful to do the substitions on pkg/MESSAGE.
It would be necessary to run pkg/MESSAGE through fmt(1)
afterwards (with an option to disable this).
Of course, a port wanting substitutions can do it fairly easily
with
${SED} ${_sedsubplist} file
themselves. Useful for ports submitted by pedants who feel
obligated to fix ${PREFIX} in the manpages. :) Letting the port
makefile do this itself allows it to ensure it's done before the
manpages are installed.
--
Outnumbered? Maybe. Outspoken? Never!
tIM...HOEk
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.3.96.980820183017.14347B-100000>